Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61168 closed defect (bug) (fixed)

Bulk select issue with with All select

Reported by: haritpanchal Owned by: audrasjb
Priority: normal Milestone: 6.6
Component: Quick/Bulk Edit Version: 6.5
Severity: normal Keywords: has-patch commit
Cc: Focuses: administration

Description

On selecting on user, all select checkbox is also getting selected in Users screen.

This seems like a consistency issue in UI.

I am attaching the video here
​https://www.awesomescreenshot.com/video/27460465?key=a83233e85424e844e7b572d2802fc00b

Attachments (1)

Users-‹-Contribution-—-WordPress.png​ (39.0 KB ) - added by haritpanchal 2 years ago.
Visual

Download all attachments as: .zip

Change History (15)

#1 @swissspidy
2 years ago

  • Focuses administration added; ui javascript performance sustainability removed

This ticket was mentioned in ​PR #6524 on ​WordPress/wordpress-develop by ​@swapnilghone9.


2 years ago
#2

  • Keywords has-patch added

Trac ticket:

#3 @swapnilghone9
2 years ago

#61252 was marked as a duplicate.

#4 @sabernhardt
2 years ago

  • Component Users → Quick/Bulk Edit
  • Keywords needs-testing added
  • Milestone Awaiting Review → 6.6
  • Version → 6.5

I experience the same behavior in Users, Plugins, Comments, Media, Categories, and Updates list tables (but not Posts or Pages) with WordPress 6.5.3.

PR 6524 removes the iedit class from the row selector, which [57745] added for Posts and Pages list tables. Is the class still necessary for those?

		if ( $(this).closest('tbody').find('tr.iedit').length ) {
			var unchecked = $(this).closest('tbody').find('tr.iedit').find(':checkbox').filter(':visible:enabled').not(':checked');
		} else {
			var unchecked = $(this).closest('tbody').find(':checkbox').filter(':visible:enabled').not(':checked');
		}
Last edited 2 years ago by sabernhardt (previous) (diff)

#5 @sabernhardt
2 years ago

#61299 was marked as a duplicate.

#6 @faisal03
2 years ago

Test Report

I tested the patch, and it is working as expected. ✅

Before

https://i.imgur.com/slwhTuN.gif

After

https://i.imgur.com/sgrcr2b.gif

Environment

  • OS: macOS
  • Localhost Server: Nginx
  • PHP: 8.2.1
  • WordPress: 6.5.3
  • Browser: Chrome
  • Theme: TT1

Actual Results

  • ✅ The patch is working fine and now selecting a user, does not selects all users.

#7 @sumitbagthariya16
2 years ago

  • Keywords needs-testing removed

Test Report ✅

I tested the patch, and it is working as expected. ✅

https://i.imgur.com/msVGerz.gif

Environment

WordPress: 6.5.3
Theme: Twenty Twenty-Four 1.1
PHP: 8.0.30
Web Server: Nginx 1.20.2
Browser: Chrome
OS: macOS Ventura 13.3

Actual Result

The patch is working fine; now, selecting a checkbox does not select all.

#8 @mohitdadhich10
2 years ago

Test Report ✅

I tested the patch, and it is working as expected. ✅

https://i.imgur.com/8HZYogs.gif

Environment


WordPress: WordPress 6.6-alpha-20240508.130236
Theme: Twenty Twenty-Four 1.1
PHP: 8.3.0
Web Server: Nginx 1.20.2
Browser: Edge Version 125.0.2535.51 and Chrome Version 125.0.6422.142
OS: Windows 11

Actual Result


The patch is working fine; now, selecting a checkbox does not select all.

#9 @swissspidy
2 years ago

  • Keywords commit added

#10 @swissspidy
2 years ago

#61403 was marked as a duplicate.

#11 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status new → assigned

Self assigning for commit.

#12 @audrasjb
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58375:

Quick/Bulk Edit: Remove the iedit class from the row selector in common.js.

This changeset fixes an issue where the "Bulk select" option was getting selected when only a single user, comment, media, or plugin was selected.

Follow-up to [57745].

Props haritpanchal, swissspidy, sabernhardt, faisal03, sumitbagthariya16, mohitdadhich10.
Fixes #61168.

#14 @swissspidy
2 years ago

#61453 was marked as a duplicate.

Note: See TracTickets for help on using tickets.