Make WordPress Core

Opened 5 weeks ago

Closed 3 weeks ago

#61180 closed defect (bug) (fixed)

Twenty Seventeen : Latest Comments Author font weight is different in both side

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing commit
Focuses: css Cc:

Description

In Theme Twenty Seventeen, The Latest Comments Author have font-weight : 700 in frontend but it is not defined in editor side.

Attachments (12)

Screenshot 2024-05-09 at 4.09.43 PM.png (222.0 KB) - added by pitamdey 5 weeks ago.
Editor View
Screenshot 2024-05-09 at 4.10.21 PM.png (1.1 MB) - added by pitamdey 5 weeks ago.
Frontend View
61180.patch (555 bytes) - added by pitamdey 5 weeks ago.
After applying this solution the issue is resolved
61180.1.patch (1.0 KB) - added by sabernhardt 5 weeks ago.
replaces outdated .editor-block-list__block class
61180.2.patch (1.5 KB) - added by sabernhardt 5 weeks ago.
also removes editor selector from blocks.css
61180.alt.patch (1.6 KB) - added by sabernhardt 5 weeks ago.
alternative: updates two selectors and removes the rulesets for the excerpt's font size
61180.alt2.patch (1.6 KB) - added by sabernhardt 5 weeks ago.
updates the class name for the comment meta links and removes three unnecessary rulesets
61180-frontend.png (21.8 KB) - added by shailu25 5 weeks ago.
Latest Comment Section in Frontend Side
61180-backend-before-patch.png (20.9 KB) - added by shailu25 5 weeks ago.
Latest Comments Author font weight - Before Patch.
61180-backend-after-patch.png (29.8 KB) - added by shailu25 5 weeks ago.
Latest Comments Author font weight - After Patch.
Screenshot 2024-05-22 at 3.20.53 PM.png (318.2 KB) - added by naeemhaque 4 weeks ago.
Latest Comments Author font weight as like frontend
alt2.png (130.9 KB) - added by naeemhaque 3 weeks ago.
after applying alt2 patch. It's wotking.

Download all attachments as: .zip

Change History (26)

@pitamdey
5 weeks ago

After applying this solution the issue is resolved

@sabernhardt
5 weeks ago

replaces outdated .editor-block-list__block class

#1 @sabernhardt
5 weeks ago

  • Focuses css added
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 6.6

The correct style rules were in the editor stylesheet already, but with the obsolete .editor-block-list__block class.

@sabernhardt
5 weeks ago

also removes editor selector from blocks.css

@sabernhardt
5 weeks ago

alternative: updates two selectors and removes the rulesets for the excerpt's font size

#2 @sabernhardt
5 weeks ago

The block's styles had set the font size at 14px in WordPress 5.0, and now the size is relative at 0.875em. The theme has an editor-related class on the front end that has also been ineffective within the editor for four years.

61180.2.patch could correct the selectors and enforce that font size in Twenty Seventeen, but I think I prefer continuing to use the block's default. 61180.alt.patch removes those rules entirely.

@sabernhardt
5 weeks ago

updates the class name for the comment meta links and removes three unnecessary rulesets

#3 @sabernhardt
5 weeks ago

I think I'm done adding patches :)

The li:before ruleset can be removed from editor-blocks.css now. It had canceled out 'content: counter(item)' styles, which were removed from the theme in version 1.9 (only a few weeks after 1.8 and WordPress 5.0).

The links do not seem to need the extra .editor-styles-wrapper class with WordPress 6.5, but they apparently needed an extra class with 5.0. I just updated the class name and kept the same specificity in 61180.alt2.patch.

Last edited 4 weeks ago by sabernhardt (previous) (diff)

#4 @karmatosed
5 weeks ago

  • Owner set to karmatosed
  • Status changed from new to assigned

Assigning to myself to test and see about getting towards commit.

#5 @shailu25
5 weeks ago

Test Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/61180/61180.alt.patch

Environment:

WordPress - 6.5.3
OS - Windows
Browser - Firefox
Theme: Twenty Seventeen
PHP - 8.1.23

Actual Results:

  • Latest Comments Author's font weight issue resolved with Patch. Both are showing same in Frontend & Backend side with patch.✅

@shailu25
5 weeks ago

Latest Comment Section in Frontend Side

@shailu25
5 weeks ago

Latest Comments Author font weight - Before Patch.

@shailu25
5 weeks ago

Latest Comments Author font weight - After Patch.

#6 @naeemhaque
4 weeks ago

Bug Report

Description

This report validates whether the indicated patch works as expected.

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/61180/61180.alt.patch

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 7.4.33
  • Server: nginx/1.23.2
  • Database: mysqli (Server: 8.0.36 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 124.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.6
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Expected Results

  1. ✅ The Latest Comments Author font-weight is the same on the frontend and editor side.

Actual Results

  1. ✅ Patch works fine: The Latest Comments Author font-weight is the same on the frontend and editor side.

@naeemhaque
4 weeks ago

Latest Comments Author font weight as like frontend

#7 @darshitrajyaguru97
3 weeks ago

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61180/61180.alt.patch

Environment:

OS: Windows
PHP: 8.1.23
WordPress: 6.5.3
Browser: Chrome
Theme: Twenty Seventeen
Plugins: None

Actual Results:

Before patch:
Screenshot: https://prnt.sc/dAbdjEqUnHVg

After patch:
Screenshot: https://prnt.sc/NQfnMYVDw6aF

✅ Patch working well as desired solution

#8 @karmatosed
3 weeks ago

@darshitrajyaguru97 and @naeemhaque as you both seem to want to test this - which is great, can you work on testing alt 2 please. I will happily move this on once you have both done that.

#9 @karmatosed
3 weeks ago

  • Owner karmatosed deleted

#10 @darshitrajyaguru97
3 weeks ago

@karmatosed I have tested alt 2 patch and It's working well. It's given the same output as the alt patch.

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61180/61180.alt2.patch

Environment:

OS: Windows
PHP: 8.1.23
WordPress: 6.5.3
Browser: Chrome
Theme: Twenty Seventeen
Plugins: None

Actual Results:

Before patch:
Screenshot: https://prnt.sc/Vc3KnJWW4COj

After patch:
Screenshot: https://prnt.sc/quNelD0gU8CV

✅ Patch working well as desired solution

#11 @karmatosed
3 weeks ago

  • Keywords commit added

Thank you @darshitrajyaguru97 I will look now to get this committed then. Thank you everyone.

#12 @karmatosed
3 weeks ago

  • Owner set to karmatosed

#13 @naeemhaque
3 weeks ago

Hi @karmatosed, I've tested the alt2 patch & it's working as like alt.

Bug Report

Description

This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/61180/61180.alt2.patch

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 7.4.33
  • Server: nginx/1.23.2
  • Database: mysqli (Server: 8.0.36 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 124.0.0.0
  • OS: macOS
  • Theme: Twenty Seventeen 3.6
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Expected Results

  1. ✅ The Latest Comments Author font-weight is the same on the frontend and editor side.

Actual Results

  1. ✅ The Latest Comments Author font-weight is the same on the frontend and editor side.

@naeemhaque
3 weeks ago

after applying alt2 patch. It's wotking.

#14 @karmatosed
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58204:

Twenty Seventeen: Resolves latest comments author font weight difference.

The latest comments author font weight was showing different between editor and front. This fixes that and also removes an extra ruleset.

Props pitamdey, sabernhardt, shailu25, naeemhaque, darshitrajyaguru97.
Fixes #61180.

Note: See TracTickets for help on using tickets.