Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 2 years ago

Closed 2 years ago

Last modified 12 months ago

#61199 closed enhancement (fixed)

Make Settings API documentation link clickable in options.php

Reported by:	timse201	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.6
Component:	Options, Meta APIs	Version:	3.0
Severity:	normal	Keywords:	good-first-bug has-patch needs-testing
Cc:		Focuses:	ui, administration

Description

in the options.php under line 325 there is a non-clickable link

The %s setting is unregistered. Unregistered settings are deprecated. See https://developer.wordpress.org/plugins/settings/settings-api/

Attachments (1)

patch.diff (790 bytes ) - added by amitraj2203 2 years ago.: Patch file.

Download all attachments as: .zip

Change History (10)

#1 @sabernhardt
2 years ago

Component General → Administration
Focuses accessibility removed
Keywords needs-patch added; changes-requested removed
Milestone Awaiting Review → Future Release
Summary no clickable link under options.php:325 → Make Settings API documentation link clickable in options.php
Version trunk → 3.0

Hi and welcome to WordPress Core Trac!

I suggest
See <a href="https://developer.wordpress.org/plugins/settings/settings-api/">documentation on the Settings API</a>.

The link has been plain text since [13785] (with updates in [14070], [32116], [34315], and [45674]).

#2 @SergeyBiryukov
2 years ago

Keywords good-first-bug added
Milestone Future Release → 6.6

@amitraj2203
2 years ago

Attachment patch.diff added

Patch file.

#3 @amitraj2203
2 years ago

Hi @sabernhardt I have submitted the patch for the same.

#4 @khokansardar
2 years ago

Keywords has-patch needs-testing added; needs-patch removed

#5 @SergeyBiryukov
2 years ago

Owner set to SergeyBiryukov
Status new → reviewing

#6 @SergeyBiryukov
2 years ago

Component Administration → Options, Meta APIs

#7 @SergeyBiryukov
2 years ago

Resolution → fixed
Status reviewing → closed

Docs: Make Settings API documentation link clickable in wp-admin/options.php.

The link is a part of the deprecation notice displayed when saving an unregistered setting.

Follow-up to [13646], [13785], [14070], [32116], [34315], [45674].

Props timse201, sabernhardt, amitraj2203, khokansardar, SergeyBiryukov.
Fixes #61199.

#8 @sabernhardt
2 years ago

Yes, separating the URL from the text string can be good, especially if/when the documentation URL changes again in the future.

#9 @sabernhardt
12 months ago

#57231 was marked as a duplicate.

Note: See TracTickets for help on using tickets.

Download in other formats: