WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61235 closed defect (bug) (fixed)

Twenty Nineteen: Button block padding is different in the editor

Reported by: pitamdey Owned by: karmatosed
Priority: normal Milestone: 6.6
Component: Bundled Theme Version:
Severity: normal Keywords: has-screenshots has-patch commit
Cc: Focuses: css

Description

In Theme Twenty Nineteen , Button Block Font Size is different in editor side & frontend side

Attachments (2)

Screenshot 2024-05-17 at 12.29.45 PM.png​ (219.7 KB ) - added by pitamdey 2 years ago.
Editor View
Screenshot 2024-05-17 at 12.30.52 PM.png​ (396.7 KB ) - added by pitamdey 2 years ago.
Frontend View

Download all attachments as: .zip

Change History (11)

@pitamdey
2 years ago

Editor View

@pitamdey
2 years ago

Frontend View

#1 @pitamdey
2 years ago

Sorry, to be more precise, it is the .wp-block-button_link font size.
Also we can see that there is a difference in the padding in the both side

Last edited 2 years ago by pitamdey (previous) (diff)

#2 @pitamdey
2 years ago

  • Summary Twenty Nineteen : Button Block Text font size is different in both side → Twenty Nineteen : Button Block Text font size & its padding is different in both side

#3 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords needs-patch added
  • Milestone Awaiting Review → Future Release
  • Summary Twenty Nineteen : Button Block Text font size & its padding is different in both side → Twenty Nineteen: Button block padding is different in the editor

The issue with a custom font size is already reported on #56443, but the padding could be fixed in the editor styles with this ticket.

This ticket was mentioned in ​PR #6576 on ​WordPress/wordpress-develop by ​@sabernhardt.
2 years ago #4

  • Keywords has-patch added; needs-patch removed

Matches the Button links' front-end padding values in the editor styles.

Trac 61235

#5 @karmatosed
2 years ago

  • Keywords needs-refresh added

Unless I am mistaken it looks like this issue needs a refresh as not passing the tests right now. @sabernhardt are you able to review that?

#6 @sabernhardt
2 years ago

  • Keywords needs-refresh removed

I refreshed the branch, and the tests pass now. Trunk (and/or my branch) apparently had a problem with PHP unit tests the first time this PR ran them.

Last edited 2 years ago by sabernhardt (previous) (diff)

#7 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Future Release → 6.6
  • Owner set to karmatosed
  • Status new → assigned

Thank you @sabernhardt I am now going to progress this through to commit then.

#8 @karmatosed
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58556:

Twenty Nineteen: Fixes button block padding within the editor.

The button block padding was not the same in the editor and front. This resolves that issue with the font size having being resolved in a previous ticket.

Props pitamdey, sabernhardt.
Fixes #61235.

​@sabernhardt commented on ​PR #6576:
2 years ago #9

committed in r58556

Note: See TracTickets for help on using tickets.