WordPress.org
Get WordPress

Make WordPress Core

Opened 12 months ago

Closed 10 months ago

Last modified 10 months ago

#61235 closed defect (bug) (fixed)

Twenty Nineteen: Button block padding is different in the editor

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: css Cc:

Description

In Theme Twenty Nineteen , Button Block Font Size is different in editor side & frontend side

Attachments (2)

Screenshot 2024-05-17 at 12.29.45 PM.png​ (219.7 KB) - added by pitamdey 12 months ago.
Editor View
Screenshot 2024-05-17 at 12.30.52 PM.png​ (396.7 KB) - added by pitamdey 12 months ago.
Frontend View

Download all attachments as: .zip

Change History (11)

@pitamdey
12 months ago

Editor View

@pitamdey
12 months ago

Frontend View

#1 @pitamdey
12 months ago

Sorry, to be more precise, it is the .wp-block-button_link font size.
Also we can see that there is a difference in the padding in the both side

Last edited 12 months ago by pitamdey (previous) (diff)

#2 @pitamdey
12 months ago

  • Summary changed from Twenty Nineteen : Button Block Text font size is different in both side to Twenty Nineteen : Button Block Text font size & its padding is different in both side

#3 @sabernhardt
11 months ago

  • Focuses css added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Nineteen : Button Block Text font size & its padding is different in both side to Twenty Nineteen: Button block padding is different in the editor

The issue with a custom font size is already reported on #56443, but the padding could be fixed in the editor styles with this ticket.

This ticket was mentioned in ​PR #6576 on ​WordPress/wordpress-develop by ​@sabernhardt.
11 months ago #4

  • Keywords has-patch added; needs-patch removed

Matches the Button links' front-end padding values in the editor styles.

Trac 61235

#5 @karmatosed
10 months ago

  • Keywords needs-refresh added

Unless I am mistaken it looks like this issue needs a refresh as not passing the tests right now. @sabernhardt are you able to review that?

#6 @sabernhardt
10 months ago

  • Keywords needs-refresh removed

I refreshed the branch, and the tests pass now. Trunk (and/or my branch) apparently had a problem with PHP unit tests the first time this PR ran them.

Last edited 10 months ago by sabernhardt (previous) (diff)

#7 @karmatosed
10 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.6
  • Owner set to karmatosed
  • Status changed from new to assigned

Thank you @sabernhardt I am now going to progress this through to commit then.

#8 @karmatosed
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58556:

Twenty Nineteen: Fixes button block padding within the editor.

The button block padding was not the same in the editor and front. This resolves that issue with the font size having being resolved in a previous ticket.

Props pitamdey, sabernhardt.
Fixes #61235.

​@sabernhardt commented on ​PR #6576:
10 months ago #9

committed in r58556

Note: See TracTickets for help on using tickets.