Make WordPress Core

Opened 2 years ago

Closed 20 months ago

Last modified 17 months ago

#61264 closed enhancement (invalid)

Move default rendering mode setting to block_editor_settings_all hook in PHP to allow customizing it

Reported by: fabiankaegy Owned by:
Priority: normal Milestone:
Component: Editor Version:
Severity: normal Keywords: has-patch needs-test-info gutenberg-merge
Cc: Focuses:

Description

Sync ticket for ​https://github.com/WordPress/gutenberg/pull/61844

Move the defaultRenderingMode property from being hardcoded in JS to being an option set in PHP via the block_editor_settings_all hook.

Change History (15)

This ticket was mentioned in ​PR #6601 on ​WordPress/wordpress-develop by ​@fabiankaegy.


2 years ago
#1

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by oglekler. ​View the logs.


2 years ago

#3 @oglekler
2 years ago

  • Summary Move default redering mode setting to block_editor_settings_all hook in PHP to allow customizing it → Move default rendering mode setting to block_editor_settings_all hook in PHP to allow customizing it

#4 @oglekler
2 years ago

  • Keywords needs-testing-info added

Hi @fabiankaegy we have just a few days before Beta 1, but the patch is small, so, it still can go into 6.6.
Can you please provide testing instructions? Thank you!

#5 @fabiankaegy
2 years ago

@oglekler The original ticket in Gutenberg has not yet reached a consensus... So this will not be ready in time for 6.6 sadly. Thanks for checking in though!

#6 @oglekler
2 years ago

  • Keywords gutenberg-merge added
  • Milestone 6.6 → 6.7

Thank you, @fabiankaegy 🙏
I am rescheduling it than to the next milestone, making space for things that still can be done in this phase.

This ticket was mentioned in ​Slack in #core-test by ankit-k-gupta. ​View the logs.


2 years ago

#8 @Ankit K Gupta
2 years ago

Hi @fabiankaegy, is this ticket ready for testing now? If so, would you mind adding some details from a manual testing perspective so that contributors can easily test? Thank you!

#9 @davidbaumwald
2 years ago

@fabiankaegy Looks like the new PR for this is ​https://github.com/WordPress/gutenberg/pull/62304.

Seems like there's still some work to do. Do you think this can be completed in time for 6.7 Beta 1 in a few hours?

#10 @fabiankaegy
2 years ago

@davidbaumwald this will not be ready for 6.7. we can move it to the 6.8 milestone

#11 @davidbaumwald
2 years ago

  • Milestone 6.7 → 6.8

@fabiankaegy Thanks!

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.


20 months ago

#13 @audrasjb
20 months ago

As per today's 6.8 bug scrub:

Hello @fabiankaegy, is this ticket still on your plate for 6.8. If not please feel free to move it to "Future Release". I'll keep it open in the milestone for now.

#14 @fabiankaegy
20 months ago

  • Milestone 6.8
  • Resolution → invalid
  • Status new → closed

Thanks for the ping here. This actually has since been resolved in Gutenberg via ​https://github.com/WordPress/gutenberg/pull/62304 so this can get closed altogether :)

#15 @wordpressdotorg
17 months ago

  • Keywords needs-test-info added; needs-testing-info removed
Note: See TracTickets for help on using tickets.