Make WordPress Core

Opened 4 weeks ago

Closed 13 days ago

Last modified 13 days ago

#61271 closed defect (bug) (fixed)

Add filter for duotone to account for gutenberg_restore_image_outer_container in classic themes

Reported by: scruffian's profile scruffian Owned by: isabel_brison's profile isabel_brison
Milestone: 6.6 Priority: normal
Severity: normal Version: trunk
Component: Editor Keywords: gutenberg-merge has-patch
Focuses: Cc:

Attachments (1)

patch.diff (2.3 KB) - added by scruffian 4 weeks ago.
backport

Download all attachments as: .zip

Change History (11)

@scruffian
4 weeks ago

backport

@ajlende commented on PR #6607:


2 weeks ago
#3

@tellthemachines I have the correct backport at https://github.com/WordPress/wordpress-develop/pull/6719

@scruffian commented on PR #6607:


2 weeks ago
#4

@tellthemachines you're right I had done this wrongly. I have updated the PR with the correct approach (I hope!)

I had incorrectly read the original PR and thought it was removing the restore_image_outer_container filter, but it was actually removing the Duotone specific filter.

#5 @isabel_brison
13 days ago

  • Component changed from General to Editor
  • Keywords gutenberg-merge added
  • Milestone changed from Awaiting Review to 6.6
  • Version set to trunk

#6 @isabel_brison
13 days ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 58313:

Editor: fix duotone filter for aligned images on classic themes.

Adds a filter to move the duotone classname to the outer wrapper on aligned images.

Props scruffian, isabel_brison, ajlende.
Fixes #61271.

@isabel_brison commented on PR #6719:


13 days ago
#7

Committed in r58313.

@isabel_brison commented on PR #6607:


13 days ago
#8

Closing this one in favour of #6719.

#9 @isabel_brison
13 days ago

In 58316:

Remove extra whitespace from restore_image_outer_container docblock.

Props mukesh27.
Follows r58313.
See #61271.

#10 @audrasjb
13 days ago

In 58317:

Docs: Fix docblock alignment in class-wp-duotone.php.

Follow-up to [58313].

Props mukesh27.
See #61271, #60699.

Note: See TracTickets for help on using tickets.