Make WordPress Core

Opened 14 months ago

Closed 14 months ago

Last modified 13 months ago

#61279 closed enhancement (fixed)

Editor: update all packages to the latest versions

Reported by: ellatrix's profile ellatrix Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

We still have one GB release to go before Beta 1, but it's good to check how everything is doing right now, and maybe already commit these updates to trunk. So far I'm not seeing any crashes.

Change History (14)

This ticket was mentioned in PR #6612 on WordPress/wordpress-develop by @ellatrix.


14 months ago
#1

  • Keywords has-unit-tests added

We still have one GB release to go before Beta 1, but it's good to check how everything is doing right now, and maybe already commit these updates to trunk. So far I'm not seeing any crashes.

Trac ticket: https://core.trac.wordpress.org/ticket/61279

@youknowriad commented on PR #6612:


14 months ago
#2

![Uploading Screenshot 2024-05-23 at 4.23.58 PM.png…]()

Something is wrong for me here in terms of styles.

@youknowriad commented on PR #6612:


14 months ago
#3

The editor seems broken for me too. I wonder if I'm doing something wrong.

![Uploading Screenshot 2024-05-23 at 4.25.08 PM.png…]()

@ellatrix commented on PR #6612:


14 months ago
#4

For me this was looking good:

https://github.com/WordPress/wordpress-develop/assets/4710635/58496224-5182-4494-b116-c82e2152b1d8

@youknowriad commented on PR #6612:


14 months ago
#5

yeah, seems like a potential cache issue. Private browser fixes the issue for me.

@youknowriad commented on PR #6612:


14 months ago
#6

Ok this is looking to me. 👍

@ellatrix commented on PR #6612:


14 months ago
#7

Tests are failing for 932895b8275d8d80fc9ccb0f6d7ae0fd455b489f. Not sure what went wrong.

@ellatrix commented on PR #6612:


14 months ago
#8

I forgot to add the new PHP files. 🤦‍♀️ All is well now.

@peterwilsoncc commented on PR #6612:


14 months ago
#9

Tests are failing for https://github.com/WordPress/wordpress-develop/commit/932895b8275d8d80fc9ccb0f6d7ae0fd455b489f. Not sure what went wrong.

@ellatrix For WP-Dev PRs you need to push to a fork in your own GH account rather than the the one in the WordPress organization. Unexpected branches get deleted every 60 seconds or so when synced from the official SVN repository and this causes the tests to fail as they're trying to checkout a non-existent commit.

@ellatrix commented on PR #6612:


14 months ago
#10

@peterwilsoncc Yes, I decided to leave it up for this one because we were close to merging.

#11 @ellatrix
14 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by r58187 and r58189. I had only included the Github PR links because I mistakenly basing the commit message on https://github.com/WordPress/wordpress-develop/commit/5afdac7e057bf4faf097079c0704f6e834fdce97.

#12 @kebbet
14 months ago

With changesets during development of 6.6, please milestone this ticket accordingly, thanks @ellatrix

#13 @ellatrix
13 months ago

  • Milestone changed from Awaiting Review to 6.6

#14 @ellatrix
13 months ago

Didn't have the permissions until now

Note: See TracTickets for help on using tickets.