Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#61287 new defect (bug)

Twenty Sixteen : Code Block Background color is not reflecting in frontend

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing
Focuses: css Cc:

Description

In theme Twenty Sixteen, The code Block Background color is not being reflected in the Frontend side

Attachments (8)

Screenshot 2024-05-24 at 11.51.03 AM.png (214.7 KB) - added by pitamdey 4 weeks ago.
Editor View
Screenshot 2024-05-24 at 11.51.10 AM.png (218.7 KB) - added by pitamdey 4 weeks ago.
Frontend View
61287.patch (1.1 KB) - added by pitamdey 4 weeks ago.
Patch for this issue
61287.2.patch (368 bytes) - added by viralsampat 4 weeks ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue. I think that add inherit instead of removed background color from code block.
back-end-code-block.png (194.6 KB) - added by viralsampat 4 weeks ago.
front-end-code-block.png (152.4 KB) - added by viralsampat 4 weeks ago.
61287.3.patch (947 bytes) - added by sabernhardt 4 weeks ago.
sets code element background to transparent when the Code block has a background, retains default gray background when user does not select background color
61287.4.patch (409 bytes) - added by viralsampat 3 weeks ago.
I have added another patch

Download all attachments as: .zip

Change History (10)

@pitamdey
4 weeks ago

Patch for this issue

@viralsampat
4 weeks ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue. I think that add inherit instead of removed background color from code block.

@sabernhardt
4 weeks ago

sets code element background to transparent when the Code block has a background, retains default gray background when user does not select background color

#1 @sabernhardt
4 weeks ago

  • Focuses css added
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to Future Release

The code element needs to keep the light gray background when it is used outside of a Code block or when the Code block does not have a user-defined background color.

#2 @viralsampat
3 weeks ago

Hello @sabernhardt

Thank you so much for your feedback.

I read your last comment and I have made the changes accordingly.

Here, I have attached my latest patch.

Thanks,

@viralsampat
3 weeks ago

I have added another patch

Note: See TracTickets for help on using tickets.