Opened 2 years ago
Closed 2 years ago
#61331 closed defect (bug) (fixed)
Plugins: Revert 6.5.3 changes for showing an admin notice on successful activation.
| Reported by: | hellofromTonya | Owned by: | hellofromTonya |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5.4 |
| Component: | Plugins | Version: | 6.5.3 |
| Severity: | normal | Keywords: | has-patch commit dev-reviewed |
| Cc: | Focuses: |
Description
With a new direction in the 6.5.4 minor to restore the Activate button's href (see #61319 / [58250]), the changesets committed for 6.5.3 (see #60992) are now dead code and will not be rendered.
After discussing in Make/Core slack, consensus is to revert both [58081] (on trunk) and [58083] (on 6.5 branch).
Quoting @costdev:
Sure, 68081 (trunk) and 68083 (6.5) should be reverted. They are part of a solution that did not achieve the intended result fully, and have been replaced, not extended, with a different solution for 6.5. If we want to introduce them later, then we still have the code stored in history to save us some time.
As @jorbin noted:
I'm not sure if it will be a clean revert since [58250] also changed some of these lines, but I would support reverting the functionality
Attachments (1)
Change History (7)
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
2 years ago
#4
@
2 years ago
- Keywords has-patch commit dev-feedback added
- Resolution fixed
- Status closed → reopened
Reopening for 2nd committer sign-off to revert r58083 on the 6.5-branch.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
In reviewing and testing the revert of [58081] on the current
trunk, the revert is clean. Pushing the revert commit shortly.