Opened 8 months ago
Closed 8 months ago
#61362 closed defect (bug) (fixed)
Twenty Seventeen: add border-style for custom Pullquote block borders
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-testing commit |
Focuses: | css | Cc: |
Description
Pull quote block border is not working in both frontend and backend when adding border to block
Video: https://jmp.sh/7mHpFrue
Attachments (2)
Change History (6)
#1
@
8 months ago
- Keywords changes-requested has-patch added
- Severity changed from minor to normal
Hi @pranitdugad Thank you for opening the issue and adding the patch.
Please remember that there are contributors with visual impairments that may not be able to see the video. There must always be a written description of the problem. This is also important because the video is hosted remotely, and it may not always be available.
It is not obvious from the description in what way the border is not working.
When a border color and border width is added to the pullquote block, but no border style is chosen, the border is not visible in the editor or front.
The reason why the borders are not showing on the video is because the border: 0
also resets the border style, and there was no border style selected in the control.
The expectation would be for the border to have a solid style by default when a color is selected.
I would like to request the following changes:
The default style for the block must stay the same. There must not be any visible borders by default.
#2
@
8 months ago
- Focuses css added; ui removed
- Keywords needs-testing added; changes-requested removed
- Milestone changed from Awaiting Review to Future Release
- Summary changed from Twenty Seventeen : Pull quote block border is not working in both frontend and backend to Twenty Seventeen: add border-style for custom Pullquote block borders
The border
property could have 0 solid
to make that the default style when the user gives the Pullquote a border width.
After applying this patch , this issue is resolved