Make WordPress Core

Opened 6 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#61369 closed enhancement (fixed)

Refactor fixture replacements for the "class_list" REST API field.

Reported by: antonvlasenko's profile antonvlasenko Owned by: oandregal's profile oandregal
Milestone: 6.6 Priority: normal
Severity: minor Version: 6.6
Component: REST API Keywords: has-patch has-unit-tests has-testing-info
Focuses: Cc:


As was rushed to be backported to Core due to time constraints, the fixture replacements for the "class_list" REST API field were not designed optimally.
These fixtures replacements need to be implemented using the WP_Test_REST_Schema_Initialization::$fixture_replacements class property, and part of the code added in needs to be removed.
This is not an issue but rather some technical debt that must be refactored.

Change History (7)

This ticket was mentioned in PR #6727 on WordPress/wordpress-develop by @antonvlasenko.

6 weeks ago

  • Keywords has-patch has-unit-tests added

#2 @antonvlasenko
6 weeks ago

  • Keywords has-testing-info added

How to test

  1. Review the changes.
  2. Make sure that GitHub CI jobs pass. If the PR is implemented incorrectly, the CI jobs will fail.

#3 @oandregal
6 weeks ago

  • Milestone changed from Awaiting Review to 6.6
  • Type changed from defect (bug) to enhancement

#4 @oandregal
6 weeks ago

  • Owner set to oandregal
  • Status changed from new to assigned

#5 @oandregal
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58340:

REST API: improve code quality for class_list field fixtures.

Follow-up to [58326], #61360.

Props antonvlasenko, oandregal.
Fixes #61369.

@antonvlasenko commented on PR #6727:

6 weeks ago

Thanks for the follow-up.

Thank you for reviewing and committing, @oandregal!

Note: See TracTickets for help on using tickets.