Make WordPress Core

Opened 5 weeks ago

Last modified 5 weeks ago

#61381 new defect (bug)

Bulk update plugins no longer working when 1 Plugin failed to update

Reported by: rickhaer's profile rickhaer Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.5.4
Component: Plugins Keywords:
Focuses: Cc:

Description

Hi! In "older" WordPress Version i used to just bulk update plugins when there were multiple plugin updates todo, which was always working fine, 1 after 1 got updated. Also when one failed, the next one was updated successfully.

But i think since WP Version 6.4.4 (not quite sure if it is only since this version or even a version before) when i do that, and 1 update failed than all the next updates are no longer updating. I need to refresh the page and do the bulk update again. So everytime 1 plugin update failed in between, all the plugin after the failed ones are no longer updating.

Steps to reproduce:

  1. Go to wp-admin/plugins.php when there are multiple updates
  2. Update them all directly after each other, so scroll threw and hit "Update now" everywhere.
  3. Make sure 1 Update failed in between (maybe by not putting in a license key into a pro update)
  4. You will see all the updates after will not update any more and you need to refresh the page.

I would really like to see, that this is working again, cause it cost a lot more time now to update, since at my sites for some reason it happens a lot that some plugin updates failing.

Attachments (1)

61381.diff (1.2 KB) - added by siliconforks 5 weeks ago.
This patch is very similar to r57615.

Download all attachments as: .zip

Change History (4)

@siliconforks
5 weeks ago

This patch is very similar to r57615.

#1 @siliconforks
5 weeks ago

This issue is similar to #60521 (and the patch I've proposed is very similar to the fix).

#2 @rickhaer
5 weeks ago

@siliconforks this seems not to be the same as your patch since this also happens in 6.5.4 still. Its not happening for all Plugins. So normal Plugin updates are working fine. But when one Plugin failed to update all in the loop after the one failed will not update anymore and the page need to be reloaded and the bulk update started again.

#3 @siliconforks
5 weeks ago

It's not the same bug as #60521, but the required fix is very similar to the fix that @costdev wrote for that bug (so much so that I copied most of the code from his fix).

I'm just making sure @costdev receives credit since I stole most of the code from him 😉

Note: See TracTickets for help on using tickets.