WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #61381, comment 5


Ignore:
Timestamp:
08/23/2024 09:27:51 PM (15 months ago)
Author:
ironprogrammer
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #61381, comment 5

    initial v1  
    1 @siliconforks, the proposed fix is nearly there! The updates continued after an error, but the admin notice for the failure isn't rendering as expected (Figure 1).
     1**UPDATED**
    22
    3 If you're able to, I would recommend creating a PR in [https://github.com/WordPress/wordpress-develop wordpress-develop] to continue this work, as it will make collaboration and code review a bit easier going forward. (But to be clear, it's fine to submit .diffs if this is what works best for you.)
     3@siliconforks, thanks for the fix! Apologies for the updated report -- I should have tested the patch in `trunk` first.
    44
    55== Test Report
    6 Patch tested: https://core.trac.wordpress.org/attachment/ticket/61381/61381.diff
     6Patch tested: https://core.trac.wordpress.org/attachment/ticket/61381/61381.diff 👍🏻
     7
     8> Edit: I tested the changes to `updates.js` by applying the patch in `wordpress-develop:trunk`, running `npm run build:dev`, and clearing the browser cache.
    79
    810=== Environment
    … …  
    1315- PHP: 8.2.22
    1416- SQLite: 3.43.2
    15 - WordPress: 6.5
     17- WordPress: `trunk`
    1618- Theme: twentytwentythree v1.2
    1719- Active Plugins:
    18  - plugin-update-failure (test mu plugin to trigger Akismet update failure)
     20 - plugin-update-failure (test mu plugin to trigger Akismet update failure, see comment:4)
    1921 - db.php (drop-in for SQLite)
    2022
    2123=== Actual Results
    2224- ✅ During bulk update, after a plugin update failure, subsequent updates proceed successfully.
    23 - ❌ After a failed bulk update, the update failures admin notice does not display as expected. The notice is styled as "success" and does not contain the list of failed updates. (See comment:4 for expected example.)
     25- ✅ After a failed bulk update, the update failures admin notice displays the failing plugin(s).
    2426
    25 === Supplemental Artifacts
    26 ''Figure 1: Bulk update failure result with patch applied.''
    27   [[Image(https://cldup.com/hZI6QNxYvh-3000x3000.png)]]
     27=== Additional Notes
     28In testing the patch against WP 6.5, the updates continued after an error, but the admin notice for the failure didn't render as expected [https://cldup.com/hZI6QNxYvh-3000x3000.png screenshot]. There are likely other UI/JS changes since 6.5 that could account for this, and I intend on checking against the latest 6.6 as well.