Plugins: Remove unassigned sprintf from wp_get_plugin_action_button()

[hellofromTonya]

[57545] introduced wp_get_plugin_action_button(). After speaking with @costdev, it appears an unassigned sprintf was accidentally included (the code line starts here). A copy/paste whoopsie.

        sprintf(
                '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s" role="button">%s</a>',
                esc_attr( $data->slug ),
                esc_url( $status['url'] ),
                /* translators: %s: Plugin name and version. */
                esc_attr( sprintf( _x( 'Install %s now', 'plugin' ), $name ) ),
                esc_attr( $name ),
                _x( 'Install Now', 'plugin' )
        );

As this code does not assign to a variable, it is not used and thus dead code. This ticket will remove it.

Removes the unused / unassigned sprintf code from wp_get_plugin_action_button().

Trac ticket: https://core.trac.wordpress.org/ticket/61420

Wondering how this was here, unnoticed...

[hellofromTonya]

Patch: ​https://github.com/WordPress/wordpress-develop/pull/6792

2 approvals. CI all green. Committing.

[hellofromTonya]

In 58402:

Plugins: Remove unassigned sprintf in wp_get_plugin_action_button().

Removes an unassigned sprintf that was accidentally included as part of [57545] in the wp_get_plugin_action_button(). A copy/paste whoopsie.

The actual used code is assigned a wee bit lower in the function within the install case.

Follow-up to [57545].

Props hellofromTonya, costdev, rajinsharwar.
Fixes #61420.

Thank you both. Committed via https://core.trac.wordpress.org/changeset/58402.

[hellofromTonya]

@jorbin @costdev this is another good candidate to backport to 6.5 branch if a 6.5.5 is planned. Also noting, it might be a good one to backport anyway as it doesn't affect production code, but rather removes dead code to avoid confusion.

[jorbin]

@hellofromTonya I agree. I think we should backport it so that it goes out if a 6.5.5 happens even if it's not a driving force for a 6.5.5

I've also reviewed [58402] and am approving it for backport.

[hellofromTonya]

Awesome. I'll backport it now. Thanks @jorbin.

[hellofromTonya]

In 58404:

Plugins: Remove unassigned sprintf in wp_get_plugin_action_button().

Removes an unassigned sprintf that was accidentally included as part of [57545] in the wp_get_plugin_action_button(). A copy/paste whoopsie.

The actual used code is assigned a wee bit lower in the function within the install case.

Follow-up to [57545].

Reviewed by jorbin.
Merges [58402] to the 6.5 branch.

Props hellofromTonya, costdev, rajinsharwar.
Fixes #61420.