WordPress.org
Get WordPress

Make WordPress Core

Opened 13 months ago

Closed 12 months ago

Last modified 12 months ago

#61424 closed enhancement (fixed)

Update en.gravatar.com links to gravatar.com

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.7 Priority: low
Severity: normal Version:
Component: General Keywords: good-first-bug has-patch
Focuses: Cc:

Description

On the user profile page and in the first comment on the hello world post, the links to Gravatar for an English language WordPress install go to en.gravatar.com.

The English version of the Gravatar now uses the base domain so these links can be set to gravatar.com to avoid an unnecessary redirct.

The links will need to remain translatable so non-English installations of WordPress can link to the correct subdomain.

Change History (10)

#1 @narenin
13 months ago

Hi @peterwilsoncc,

I have submitted PR with fix.

Last edited 13 months ago by narenin (previous) (diff)

This ticket was mentioned in ​PR #6796 on ​WordPress/wordpress-develop by ​@narenin.
13 months ago #2

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/61424

#3 @SergeyBiryukov
13 months ago

  • Milestone changed from Awaiting Review to 6.7

#4 follow-up: @knutsp
13 months ago

Suggests the translator comment is extended to reflect that the url can be localized using a language specific subdomain, with an example. With en.gravatar.com this was more obvious.

After this change the translations become fuzzy, which may lead to thinking it's no longer actually translatable/localizable. There are many such.

Last edited 13 months ago by knutsp (previous) (diff)

#5 in reply to: ↑ 4 @peterwilsoncc
13 months ago

Replying to knutsp:

Suggests the translator comment is extended to reflect that the url can be localized using a language specific subdomain, eith an example. With en.gravatar.com this was more obvious.

After this change the translations become fuzzy, which may lead to thinking it's no longer actually translatable/localizable. There are many such.

I agree, extending the translator comment to emphasis the URL is translatable is a good idea. The same approach is used for various wordpress.org links, for example the download URL.

​@narenin commented on ​PR #6796:
12 months ago #6

@peterwilsoncc Thanks for the review I have implemented the suggestions.

#7 @peterwilsoncc
12 months ago

@knutsp The ​linked pull request includes translator comments directing polyglots to use the localized version of gravatar.com. Are you able to review them and advise if they need refining.

#8 @knutsp
12 months ago

Looks good to me.

#9 @peterwilsoncc
12 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 58810:

General: Update English Gravatar links.

Replace links to en.gravatar.com with links to gravatar.com as the english site now uses the base domain. This avoids an unnecessary redirect for english language sites.

The links remain translatable for non-english versions of WordPress.

Props narenin, knutsp.
Fixes #61424.

Note: See TracTickets for help on using tickets.