Make WordPress Core

Opened 5 weeks ago

Last modified 5 weeks ago

#61424 new enhancement

Update en.gravatar.com links to gravatar.com

Reported by: peterwilsoncc's profile peterwilsoncc Owned by:
Milestone: 6.7 Priority: low
Severity: normal Version:
Component: General Keywords: good-first-bug has-patch
Focuses: Cc:

Description

On the user profile page and in the first comment on the hello world post, the links to Gravatar for an English language WordPress install go to en.gravatar.com.

The English version of the Gravatar now uses the base domain so these links can be set to gravatar.com to avoid an unnecessary redirct.

The links will need to remain translatable so non-English installations of WordPress can link to the correct subdomain.

Change History (5)

#1 @narenin
5 weeks ago

Hi @peterwilsoncc,

I have submitted PR with fix.

Last edited 5 weeks ago by narenin (previous) (diff)

This ticket was mentioned in PR #6796 on WordPress/wordpress-develop by @narenin.


5 weeks ago
#2

  • Keywords has-patch added; needs-patch removed

#3 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 6.7

#4 follow-up: @knutsp
5 weeks ago

Suggests the translator comment is extended to reflect that the url can be localized using a language specific subdomain, with an example. With en.gravatar.com this was more obvious.

After this change the translations become fuzzy, which may lead to thinking it's no longer actually translatable/localizable. There are many such.

Last edited 5 weeks ago by knutsp (previous) (diff)

#5 in reply to: ↑ 4 @peterwilsoncc
5 weeks ago

Replying to knutsp:

Suggests the translator comment is extended to reflect that the url can be localized using a language specific subdomain, eith an example. With en.gravatar.com this was more obvious.

After this change the translations become fuzzy, which may lead to thinking it's no longer actually translatable/localizable. There are many such.

I agree, extending the translator comment to emphasis the URL is translatable is a good idea. The same approach is used for various wordpress.org links, for example the download URL.

Note: See TracTickets for help on using tickets.