Opened 9 months ago
Closed 7 months ago
#61429 closed defect (bug) (duplicate)
Twenty Nineteen: Media & Text Block text color and font size issue on editor side.
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | minor | Version: | |
Component: | Bundled Theme | Keywords: | has-testing-info has-patch needs-testing 2nd-opinion |
Focuses: | Cc: |
Description
In Twenty Nineteen, Media & Text Block text colour and font-size not showing on the editor side even after adding text colour and font size. While it's working correctly on the frontside (as shown in video)
Video: https://jmp.sh/9NZAkNmr
Attachments (2)
Change History (15)
#1
@
9 months ago
@pranitdugad Here, is the report for this issue.
Reproduction Report
Description
I am unable to replicate the issue with 2019
theme.
Environment
- WordPress: 6.5.4
- PHP: 8.2.15
- Server: nginx/1.25.3
- Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
- Browser: Chrome 125.0.0.0
- OS: macOS
- Theme: Twenty Nineteen Version: 2.8
- MU Plugins:
- Safe Autoloaded Options Limit Test (MU Plugin) 1.0
- Plugins:
- Test Reports 1.1.0
Actual Results
- I am successfully able to change the font size.
Additional Notes
- Any additional details worth mentioning.
Supplemental Artifacts
Please check this visual here : https://drive.google.com/file/d/13Ktg5hTPxVJ-bjs8rrt2S6cJllkJD0YC/view?usp=sharing
#3
in reply to:
↑ 2
@
9 months ago
Replying to krupajnanda:
@krupajnanda Thanks for Report But i am Facing the same issue on below Enviorment
WordPress: 6.5.4
PHP: 8.1.23
Server: nginx/1.25.3
Database: mysqli (Server: 8.0.16)
Browser: Chrome 125.0.0.0
OS: macOS
Theme: Twenty Nineteen Version: 2.8
#4
@
9 months ago
Hey @pranitdugad
Thank you for sharing the details. I will try to retest and will update you.
#5
@
9 months ago
Steps to reproduce:
- Activate Twenty Nineteen as your theme.
- Create or edit a post.
- Insert a Media & Text block, add an image, and type several words in the Content area (Paragraph block).
- Select that Media & Text block again. You could use the breadcrumb link at the bottom or the 'Select parent block' button in the block toolbar.
- Duplicate the block (to have both the default style and customized options).
- With the second Media & Text block selected, change the colors and text size in the sidebar.
- Save the post, and view it on the front end to compare styles.
#7
@
9 months ago
This looks like it does have a patch, so I am going to move it to future release for testing.
#11
@
7 months ago
- Keywords 2nd-opinion added
Thank you for your patch @pranitdugad, we have taken some different approaches in other tickets so I wanted to make sure this was aligned by getting a 2nd opinion before commiting.
@sabernhardt looping you in as you have explored this ticket already. I am curious about the approach in this patch of hardcoding and font. For me I think we have done different ones in other themes so checking before look to progress this.
#12
@
7 months ago
Note that the patch on #61474 makes the same changes as 61429.patch, but 61474.1.2.patch edits the SCSS.
To start, I agree with removing or replacing the paragraph's font size rule in the editor. Discussion about that can continue on #60880.
I still have not formed a good idea of what to do with the white or gray text color that Twenty Nineteen sets to contrast against its background colors. However, we might want to combine some of the tickets that touch the same issue (on #49931?):
- #61429 Media & Text block
- #61474 Latest Posts block with post content
- #61138 also Latest Posts block, but its patch proposes changing *front-end* color styles in addition to padding
- #49931 blocks with custom text colors inside a Group block with one of the theme's background colors
(#59164 mentions the background color, but that ticket is more about having the default blue when the Site Title is linked.)
After removing this Css , this issue is resolved