Make WordPress Core

Opened 17 months ago

Closed 15 months ago

Last modified 6 months ago

#61429 closed defect (bug) (duplicate)

Twenty Nineteen: Media & Text Block text color and font size issue on editor side.

Reported by: pranitdugad's profile pranitdugad Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-test-info has-patch needs-testing 2nd-opinion
Focuses: Cc:

Description

In Twenty Nineteen, Media & Text Block text colour and font-size not showing on the editor side even after adding text colour and font size. While it's working correctly on the frontside (as shown in video)

Video: https://jmp.sh/9NZAkNmr

Attachments (2)

61429.patch (1.8 KB) - added by pranitdugad 17 months ago.
After removing this Css , this issue is resolved
Screenshot 2024-06-14 at 9.45.20 AM.png (401.7 KB) - added by pranitdugad 17 months ago.
I have attached Screenshot for better Understanding

Download all attachments as: .zip

Change History (16)

@pranitdugad
17 months ago

After removing this Css , this issue is resolved

#1 @krupajnanda
17 months ago

@pranitdugad Here, is the report for this issue.

Reproduction Report

Description

I am unable to replicate the issue with 2019 theme.

Environment

  • WordPress: 6.5.4
  • PHP: 8.2.15
  • Server: nginx/1.25.3
  • Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen Version: 2.8
  • MU Plugins:
    • Safe Autoloaded Options Limit Test (MU Plugin) 1.0
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. I am successfully able to change the font size.

Additional Notes

  • Any additional details worth mentioning.

Supplemental Artifacts

Please check this visual here : https://drive.google.com/file/d/13Ktg5hTPxVJ-bjs8rrt2S6cJllkJD0YC/view?usp=sharing

#2 follow-up: @krupajnanda
17 months ago

  • Keywords 2nd-opinion has-testing-info added

#3 in reply to: ↑ 2 @pranitdugad
17 months ago

Replying to krupajnanda:

@krupajnanda Thanks for Report But i am Facing the same issue on below Enviorment

WordPress: 6.5.4
PHP: 8.1.23
Server: nginx/1.25.3
Database: mysqli (Server: 8.0.16)
Browser: Chrome 125.0.0.0
OS: macOS
Theme: Twenty Nineteen Version: 2.8

@pranitdugad
17 months ago

I have attached Screenshot for better Understanding

#4 @krupajnanda
17 months ago

Hey @pranitdugad
Thank you for sharing the details. I will try to retest and will update you.

#5 @sabernhardt
17 months ago

Steps to reproduce:

  1. Activate Twenty Nineteen as your theme.
  2. Create or edit a post.
  3. Insert a Media & Text block, add an image, and type several words in the Content area (Paragraph block).
  4. Select that Media & Text block again. You could use the breadcrumb link at the bottom or the 'Select parent block' button in the block toolbar.
  5. Duplicate the block (to have both the default style and customized options).
  6. With the second Media & Text block selected, change the colors and text size in the sidebar.
  7. Save the post, and view it on the front end to compare styles.

#6 @karmatosed
17 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

#7 @karmatosed
17 months ago

This looks like it does have a patch, so I am going to move it to future release for testing.

#8 @karmatosed
16 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#9 @karmatosed
16 months ago

  • Keywords needs-testing added; 2nd-opinion removed

#10 @karmatosed
15 months ago

  • Owner karmatosed deleted

#11 @karmatosed
15 months ago

  • Keywords 2nd-opinion added

Thank you for your patch @pranitdugad, we have taken some different approaches in other tickets so I wanted to make sure this was aligned by getting a 2nd opinion before commiting.

@sabernhardt looping you in as you have explored this ticket already. I am curious about the approach in this patch of hardcoding and font. For me I think we have done different ones in other themes so checking before look to progress this.

#12 @sabernhardt
15 months ago

Note that the patch on #61474 makes the same changes as 61429.patch, but 61474.1.2.patch edits the SCSS.

To start, I agree with removing or replacing the paragraph's font size rule in the editor. Discussion about that can continue on #60880.

I still have not formed a good idea of what to do with the white or gray text color that Twenty Nineteen sets to contrast against its background colors. However, we might want to combine some of the tickets that touch the same issue (on #49931?):

  • #61429 Media & Text block
  • #61474 Latest Posts block with post content
  • #61138 also Latest Posts block, but its patch proposes changing *front-end* color styles in addition to padding
  • #49931 blocks with custom text colors inside a Group block with one of the theme's background colors

(#59164 mentions the background color, but that ticket is more about having the default blue when the Site Title is linked.)

#13 @sabernhardt
15 months ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Let's keep the discussion about automatic contrast text colors when setting a background color preset on #49931.

#14 @wordpressdotorg
6 months ago

  • Keywords has-test-info added; has-testing-info removed
Note: See TracTickets for help on using tickets.