'src' not in $attr for wp_get_loading_optimization_attributes

[prestonwordsworth]

The relevant ​dev note has the following snippet:

function set_fetchpriority_high_on_specific_image( $loading_attrs, $tag_name, $attr, $context ) {
    if ( 'img' === $tag_name ) {
        if (
            'the_content' === $context &&
            isset( $attr['src'] ) &&
            $attr['src'] === 'https://example.org/a-specific-image.jpg'
        ) {
            $loading_attrs['fetchpriority'] = 'high';
        } else {
            unset( $loading_attrs['fetchpriority'] );
        }
    }
    return $loading_attrs;
}
add_filter(
    'wp_get_loading_optimization_attributes',
    'set_fetchpriority_high_on_specific_image',
    10,
    4
);

'src', however, hasn’t made it into $attr array yet:

        $optimization_attrs = wp_get_loading_optimization_attributes(
                'img',
                array(
                        'width'         => $width,
                        'height'        => $height,
                        'loading'       => $loading_val,
                        'fetchpriority' => $fetchpriority_val,
                        'decoding'      => $decoding_val,
                ),
                $context
        );

[joemcgill]

Hi @prestonwordsworth, welcome to Trac!

The main place where attributes are set up for this filter are in wp_img_tag_add_loading_optimization_attrs(), which does not pass the src nor the actual image to wp_get_loading_optimization_attributes() where the filter is called. There are other places where the src is passed, like in get_header_image_tag() or WP_Widget_Media_Image::render_media, but it probably makes sense to make this consistent.

Thanks for the report!

[prestonwordsworth]

Many thanks for confirming that this is a case, @joemcgill!

So is it currently possible to change the fetchpriority or decoding of a specific image using a filter?

[adamsilverstein]

A unit test to validate would be nice to have

[joemcgill]

Thanks for the PR, @deepakrohilla! This looks pretty good. I'm going to add this to the 6.7 milestone and get a proper code review. It will be great to add unit tests for this.

Trac ticket:

[deepakrohilla]

Thanks @joemcgill I have added test cases in PR ,Please review 

@deepakrohillas Left some suggestion other then it looks good to me.

[mukesh27]

@deepakrohilla, I’ve left some feedback on the PR!

@adamsilverstein or @joemcgill, could one of you please assign yourself for the owner?

[flixos90]

In 58974:

Media: Consistently pass 'src' attribute to wp_get_loading_optimization_attributes().

A common use-case for the 'wp_get_loading_optimization_attributes' filter is to modify attributes based on the 'src' attribute. However, the wp_img_tag_add_loading_optimization_attrs() was not passing that attribute to the function as expected, which would make such usage of the filter unreliable. This changeset ensures the 'src' attribute is also passed in this scenario. All other calls to wp_get_loading_optimization_attributes() already included the attribute.

Props deepakrohilla, prestonwordsworth, mukesh27, adamsilverstein, joemcgill, flixos90.
Fixes #61436.
See #58893.

Committed in https://core.trac.wordpress.org/changeset/58974