WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 8 months ago

Last modified 6 months ago

#61437 closed defect (bug) (fixed)

Twenty Nineteen: Button block Appearance setting (font-weight) is not working.

Reported by: pranitdugad's profile pranitdugad Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch changes-requested commit
Focuses: css Cc:

Description

In Twenty Nineteen, Button Block's Appearance setting option is not working on both frontend and backend.

Steps to reproduce the issue -

  1. Add a Button Block to the editor
  2. Add some text to the button
  3. Go to block setting and enable appearance setting
  4. Select Any Appearance option.

Its Not showing any font-weight added to text in button block

Attachments (3)

61437.patch​ (704 bytes) - added by pranitdugad 10 months ago.
After applying this patch , this issue is resolved
61437.1.patch​ (583 bytes) - added by pitamdey 9 months ago.
Updated Patch
Button blocks font weight and text decoration.txt​ (4.0 KB) - added by sabernhardt 9 months ago.
sample blocks for default styles plus custom font weight and text decoration settings

Download all attachments as: .zip

Change History (11)

@pranitdugad
10 months ago

After applying this patch , this issue is resolved

@pitamdey
9 months ago

Updated Patch

This ticket was mentioned in ​PR #6831 on ​WordPress/wordpress-develop by ​@sabernhardt.
9 months ago #1

  • Keywords has-patch added

Inherits custom font weight and text decoration settings, both on the front end and within the editor.

Trac 61437

#2 @sabernhardt
9 months ago

  • Focuses css added
  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 6.7

The default font-weight needs to remain bold, while adding support for other weights.

The custom text-decoration would need an adjustment too, at least on the front end (I updated both front end and editor styles in PR 6831).

Last edited 8 months ago by sabernhardt (previous) (diff)

@sabernhardt
9 months ago

sample blocks for default styles plus custom font weight and text decoration settings

#3 @karmatosed
9 months ago

  • Keywords changes-requested added
  • Milestone changed from 6.7 to Future Release

I think we need to have some adjustments made for this based on the last comment so for now moving this out into future release.

#4 @karmatosed
9 months ago

  • Keywords needs-testing removed

#5 @karmatosed
8 months ago

  • Milestone changed from Future Release to 6.7
  • Owner set to karmatosed
  • Status changed from new to assigned

Let's see what we can do about testing and moving this one on. Putting it into the next release to do that.

#6 @karmatosed
8 months ago

  • Keywords commit added

In testing I can confirm that this resolves with the patch. Thank you everyone. I will now be adding commit to progress this.

#7 @karmatosed
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58851:

Twenty Nineteen: Fixes Button block not changing appearance settings.

The Button block isn't reflecting appearance settings. This fix keeps the default as font-weight bold but also adds support for other weights.

Props pranitdugad, pitamdey, sabernhardt.
Fixes #61437.

​@sabernhardt commented on ​PR #6831:
6 months ago #8

Committed in r58851

Note: See TracTickets for help on using tickets.