Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61437 closed defect (bug) (fixed)

Twenty Nineteen: Button block Appearance setting (font-weight) is not working.

Reported by: pranitdugad Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: minor Keywords: has-patch changes-requested commit
Cc: Focuses: css

Description

In Twenty Nineteen, Button Block's Appearance setting option is not working on both frontend and backend.

Steps to reproduce the issue -

  1. Add a Button Block to the editor
  2. Add some text to the button
  3. Go to block setting and enable appearance setting
  4. Select Any Appearance option.

Its Not showing any font-weight added to text in button block

Attachments (3)

61437.patch (704 bytes ) - added by pranitdugad 2 years ago.
After applying this patch , this issue is resolved
61437.1.patch (583 bytes ) - added by pitamdey 2 years ago.
Updated Patch
Button blocks font weight and text decoration.txt (4.0 KB ) - added by sabernhardt 2 years ago.
sample blocks for default styles plus custom font weight and text decoration settings

Download all attachments as: .zip

Change History (11)

@pranitdugad
2 years ago

After applying this patch , this issue is resolved

@pitamdey
2 years ago

Updated Patch

This ticket was mentioned in PR #6831 on WordPress/wordpress-develop by @sabernhardt.


2 years ago
#1

  • Keywords has-patch added

Inherits custom font weight and text decoration settings, both on the front end and within the editor.

Trac 61437

#2 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords needs-testing added
  • Milestone Awaiting Review6.7

The default font-weight needs to remain bold, while adding support for other weights.

The custom text-decoration would need an adjustment too, at least on the front end (I updated both front end and editor styles).

Version 0, edited 2 years ago by sabernhardt (next)

@sabernhardt
2 years ago

sample blocks for default styles plus custom font weight and text decoration settings

#3 @karmatosed
2 years ago

  • Keywords changes-requested added
  • Milestone 6.7Future Release

I think we need to have some adjustments made for this based on the last comment so for now moving this out into future release.

#4 @karmatosed
2 years ago

  • Keywords needs-testing removed

#5 @karmatosed
2 years ago

  • Milestone Future Release6.7
  • Owner set to karmatosed
  • Status newassigned

Let's see what we can do about testing and moving this one on. Putting it into the next release to do that.

#6 @karmatosed
2 years ago

  • Keywords commit added

In testing I can confirm that this resolves with the patch. Thank you everyone. I will now be adding commit to progress this.

#7 @karmatosed
2 years ago

  • Resolutionfixed
  • Status assignedclosed

In 58851:

Twenty Nineteen: Fixes Button block not changing appearance settings.

The Button block isn't reflecting appearance settings. This fix keeps the default as font-weight bold but also adds support for other weights.

Props pranitdugad, pitamdey, sabernhardt.
Fixes #61437.

@sabernhardt commented on PR #6831:


2 years ago
#8

Committed in r58851

Note: See TracTickets for help on using tickets.