Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 16 months ago

#61458 closed task (blessed) (fixed)

Update recommended version of MariaDB to 10.5 or later

Reported by: peterwilsoncc Owned by: hellofromTonya
Priority: normal Milestone: 6.6
Component: Site Health Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description (last modified by peterwilsoncc)

MariaDB 10.4 has reached the end of life with 10.4.34 being the final release.

To ensure WordPress is recommending a supported version of the software, the recommended version should be updated to 10.5 or greater.

See ​#meta7679 for WordPress.org changes.

Change History (12)

This ticket was mentioned in ​PR #6848 on ​WordPress/wordpress-develop by ​@peterwilsoncc.


2 years ago
#1

  • Keywords has-patch added

MariaDB 10.4 has reached the end of life with 10.4.34 being the final release.

To ensure WordPress is recommending a supported version of the software, the recommended version should be updated to 10.5 or greater.

https://core.trac.wordpress.org/ticket/61458

​@mukesh27 commented on ​PR #6848:


2 years ago
#2

@peterwilsoncc do we needs to update unit test workflow file?

​@peterwilsoncc commented on ​PR #6848:


2 years ago
#3

do we needs to update unit test workflow file?

I don't think so, the test in question pulls the version number from the readme file.

​https://github.com/WordPress/wordpress-develop/blob/f08a36944570fc2522ddb9f096a6b932c0529182/tests/phpunit/tests/readme.php#L63-L85

​@peterwilsoncc commented on ​PR #6848:


2 years ago
#4

Example of a failed PHPUnit run without the changes to the site health file. ​https://github.com/WordPress/wordpress-develop/actions/runs/9559915819/job/26351138684

This ticket was mentioned in ​Slack in #core by costdev. ​View the logs.


2 years ago

#6 @peterwilsoncc
2 years ago

In the ​linked pull request:

  • Update readme to recommend MariaDB 10.5 or greater
  • Update the Site Health report for same
  • Unskip the Site Health tests test_mysql_recommended_version_matches_readme_html() and test_mariadb_recommended_version_matches_readme_html() to run on all branches as they ensure the readme and Site Health are consistent without regard to EOL status

#7 @peterwilsoncc
2 years ago

  • Description modified (diff)

#8 @hellofromTonya
2 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 6.6
  • Type enhancement → task (blessed)

Patch: ​https://github.com/WordPress/wordpress-develop/pull/6848

As @peterwilsoncc noted, the patch combines the individual commits done for 10.4:

  • General bump in the readme as a follow-up to [53435].
  • Site Health bump as a follow-up to [54069].
  • It will now run the tests on all branches with this change, as a follow-up to [53435].

​LGTM for commit 👍

​The Requirements page is now updated with this recommendation, as its Meta ticket closed today ​https://meta.trac.wordpress.org/ticket/7679 👍

Changing this ticket to Blessed Task (as it was for the last bump) and moving it into the 6.6 milestone.

#9 @hellofromTonya
2 years ago

  • Owner set to hellofromTonya
  • Status new → reviewing

Prepping the commit now, which will resolve the failing tests.

#10 @hellofromTonya
2 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 58432:

Site Health: Bump the recommended MariaDB version.

MariaDB 10.4 reaches EOL (“End of Life”) on 18 June 2024. The recommended minimum is bumped to 10.5 for now, whose EOL is 24 June 2025.

Also removes the skip in tests to allow the tests to run on all branches with this change.

References:

Follow-up to [55665], [52420], [53435], [54069], [54076].

Props peterwilsoncc, dd32, costdev, mukesh27, hellofromTonya.
Fixes #61458.
See ​#meta7679.

#12 @desrosj
16 months ago

  • Component General → Site Health
Note: See TracTickets for help on using tickets.