Make WordPress Core

Opened 5 months ago

Last modified 5 months ago

#61478 new defect (bug)

Twenty Twenty-One : Excerpt Block "Read More" text color is not showing on frontend

Reported by: pranitdugad's profile pranitdugad Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-screenshots has-testing-info has-patch
Focuses: Cc:

Description

In Twenty Twenty-One, Excerpt Block "Read More" button text colour is not showing on the frontend while on the backend it's working fine
Also, I have checked other themes, they seem to be working fine in them.

Attachments (4)

Screenshot 2024-06-21 at 12.15.29 PM.png (81.1 KB) - added by pranitdugad 5 months ago.
I have attached Screenshot for better Understanding
Screenshot 2024-06-21 at 12.14.38 PM.png (450.8 KB) - added by pranitdugad 5 months ago.
SCR-20240621-itnn.png (48.7 KB) - added by karmatosed 5 months ago.
Showing front in testing
SCR-20240621-iupy.png (189.2 KB) - added by karmatosed 5 months ago.
Editor settings

Download all attachments as: .zip

Change History (11)

@pranitdugad
5 months ago

I have attached Screenshot for better Understanding

#1 @karmatosed
5 months ago

  • Keywords needs-patch added

Thank you for your report. I just tested this and have some differing feedback. It looks like you might not be using the latest version in the sense of you don't have link settings on your block. However, what seems to be the problem is the non-hover setting isn't getting picked up. It is fixed at the default one for the theme. You can however change the hover.

I have attached that to show in a screenshot to see the different settings I see. What I would recommend here is a patch to fix the following:

  • Default text on link to work on this block.

@karmatosed
5 months ago

Showing front in testing

@karmatosed
5 months ago

Editor settings

#2 @narenin
5 months ago

  • Keywords has-testing-info added

Hi @karmatosed

I have tried to replicate this issue but it is working fine as you can check in an attached video.

https://streamable.com/ezp6o1

Environment

WordPress: 6.6-beta2-58392-src
PHP: 8.3.7
Server: nginx/1.25.4
Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
Browser: Chrome 125.0.0.0
OS: macOS
Theme: Twenty Twenty-One Version 2.2
MU Plugins: None activated
Plugins:

Please let me know if I am missing anything.

Last edited 5 months ago by narenin (previous) (diff)

#3 @karmatosed
5 months ago

@narenin as you can see I replicated it this morning using latest version. Can you try using those colors - I doubt that is the issue. Also in future can you avoid videos for accessibility reasons and upload a screenshot please, thank you.

This ticket was mentioned in PR #6870 on WordPress/wordpress-develop by @narenin.


5 months ago
#4

  • Keywords has-patch added; needs-patch removed

#5 @narenin
5 months ago

Hi @karmatosed

Can you try using those colors - I doubt that is the issue. '

Yes you are correct, I can replicate with that.

Also I have added patch for this.

https://github.com/WordPress/wordpress-develop/pull/6870

Also in future can you avoid videos for accessibility reasons and upload a screenshot please, thank you.

Sure I will take care of this.

#6 @karmatosed
5 months ago

Hi @narenin thank you so much. I do wonder if this could be done in the block itself as you are calling directly those classes? If it is at all possible to fix there over in the theme it would be incredible and great for everyone.

If that isn't the case we can absolutely see about progressing this through just for this theme. I would like to see if we keep the default color in your solution though.

#7 @narenin
5 months ago

Hi @karmatosed

Thanks for the feedback.

I have made those changes so that it's not applied to Excerpt Block by excluding that block link.

We can also remove that code because it is applying to Link when block has background color and link text color and I believe if someone set both these color link text color should shown according to setting.

Please share your valuable thought on this.


Note: See TracTickets for help on using tickets.