WordPress.org
Get WordPress

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#61494 closed defect (bug) (fixed)

Unused $tag_name variable in WP_HTML_Tag_Processor::set_attribute

Reported by: davidbinda's profile david.binda Owned by: audrasjb's profile audrasjb
Milestone: 6.6 Priority: normal
Severity: minor Version: 6.6
Component: HTML API Keywords: has-patch commit
Focuses: Cc:

Description

After r58473 there is an unused $tag_name variable in WP_HTML_Tag_Processor::set_attribute. https://core.trac.wordpress.org/browser/trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php?rev=58473#L2975

The variable was introduced in r58472 but the follow-up r58473 made it unused.

The issue only affects trunk, not the 6.5 branch where the variable does not exist.

Attachments (1)

61494.diff​ (474 bytes) - added by david.binda 4 months ago.

Download all attachments as: .zip

Change History (6)

@david.binda
4 months ago

#1 @audrasjb
4 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.6
  • Owner set to audrasjb
  • Severity changed from normal to minor
  • Status changed from new to accepted

Thanks for spotting this!
Moving to 6.6.

#2 @mukesh27
4 months ago

  • Keywords commit added

Nice catch!

Ready for commit!

#4 @audrasjb
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 58559:

HTML API: Remove unused $tag_name variable in WP_HTML_Tag_Processor::set_attribute.

Follow-up to [58472], [58473].

Props davidbinda.
Fixes #61494.

​@audrasjb commented on ​PR #6898:
4 months ago #5

Thanks for the PR but we already had a patch for this.
https://core.trac.wordpress.org/attachment/ticket/61494/61494.diff

Note: See TracTickets for help on using tickets.