Make WordPress Core

Opened 9 months ago

Last modified 5 months ago

#61534 new defect (bug)

if debug mode is true and go to the site-heath page showing extra margin top at admin-menu

Reported by: fahem's profile fahem Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Site Health Keywords: dev-feedback
Focuses: ui, administration Cc:

Description

when WP_DEBUG is true and we go to the site-health page there is an extra margin-top showing in the admin menu bar

Attachments (2)

image 6344978.jpg (166.3 KB) - added by fahem 9 months ago.
image 6344978.png (240.5 KB) - added by fahem 9 months ago.

Download all attachments as: .zip

Change History (12)

@fahem
9 months ago

This ticket was mentioned in PR #6941 on WordPress/wordpress-develop by @fahem.


9 months ago
#1

  • Keywords has-patch added

remove margin-top CSS from admin-menu.css file

Trac ticket: https://core.trac.wordpress.org/ticket/61534

#2 follow-up: @sabernhardt
9 months ago

  • Keywords reporter-feedback added

Hi and welcome to WordPress Core Trac!

I do not think the margin is the problem, but the page seems to have a php-error body class without a visible error message. Could you determine if and/or how that class was added? (See ticket:58449#comment:1)

Related tickets include: #51383, #58449, #58455

#3 in reply to: ↑ 2 @fahem
9 months ago

define( 'WP_DEBUG', true ); then the php-error class added

@fahem
9 months ago

#4 @fahem
9 months ago

This only happens on the Site Health page only, with no plugins, and the PR 2490 fixed it

#5 @sabernhardt
9 months ago

  • Component changed from Menus to Site Health
  • Keywords reporter-feedback removed

#6 @sabernhardt
9 months ago

  • Keywords dev-feedback added; has-patch removed

The ticket may be a duplicate of #51383 because the patch there should fix the margin issue, but could the Site Health page have a separate issue related to a suppressed error or something like that?

#7 @siliconforks
9 months ago

When I try this with a Git checkout, it seems that this error is occurring: "disk_free_space(): No such file or directory".

It is happening here:

https://github.com/WordPress/wordpress-develop/blob/57910f67dd4ba8b1db1a5699be916ce0c805a69b/src/wp-admin/includes/class-wp-site-health.php#L1820

There is no wp-content/upgrade directory (I guess because this is a fresh install from Git - nothing has been upgraded yet).

This ticket was mentioned in Slack in #core by fahem. View the logs.


8 months ago

#10 @hellofromTonya
5 months ago

  • Version 6.6 deleted

I'm not seeing changes in 6.6.0 that directly relate to this issue. Resetting Version, i.e. until a root cause is found.

Note: See TracTickets for help on using tickets.