Make WordPress Core

Opened 5 months ago

Last modified 5 months ago

#61542 new enhancement

Reading Settings static front page dropdown field alignment issue

Reported by: fahem's profile fahem Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: ui, administration Cc:

Description

Reading Settings static front page dropdown fields alignment issue found

Attachments (3)

image.png (88.7 KB) - added by fahem 5 months ago.
edit.css (37.1 KB) - added by fahem 5 months ago.
61542.diff (414 bytes) - added by Shital Patel 5 months ago.
css updated.

Download all attachments as: .zip

Change History (5)

@fahem
5 months ago

@fahem
5 months ago

This ticket was mentioned in PR #6946 on WordPress/wordpress-develop by @fahem.


5 months ago
#1

Reading Settings static front page dropdown field alignment issue

Trac ticket: https://core.trac.wordpress.org/ticket/61542

@Shital Patel
5 months ago

css updated.

#2 @sabernhardt
5 months ago

  • Focuses administration added

The left margin value of 18px comes from [6588], assigned to front page settings in [13971].

Adjusting for Reading Settings page and/or Export

The relevant part of PR 6946 proposes to increase only the Reading Settings fields' margin from 18 to 24 pixels.

  1. If the margin is only adjusted for the Reading Settings page, #front-page-warning would need the same as #front-static-pages ul. The warning appears when selecting the same page for both front and post pages (and saving changes).
  2. Also consider making the same adjustment(s) to ul.export-filters. Those filter option fields appear in Tools > Export when selecting Posts, Pages or Media.
  3. To align with the text above, the margin would be about 24px for large screens and about 33px for the (max-width: 782px) media query. These fields do not have a different margin for smaller screens yet.

Adjusting for settings and export pages plus nested categories

61542.diff suggests editing the margin value from 18 to 25 pixels for multiple places in the same ruleset.

  • Reading Settings page options and warning
  • Export filters
  • Nested categories in Quick Edit and Bulk Edit (.inline-editor ul.cat-checklist ul)
  • Nested categories in the Classic Editor post meta box and/or the Menus page (at least .categorydiv ul.categorychecklist ul is in both places)

For the category lists:

  1. Nested categories do not line up with the text for parent categories in the block editor either, where the margin is 16px.
  2. The Quick/Bulk Edit checkboxes have an extra margin, so it would be more difficult to make them align perfectly.
  3. If the Classic Editor post meta box margins are updated, #sticky-span probably would need the same margin for the "Stick this post to the front page" option under "Public" in the Publish meta box.
  4. The patch on #31354 is not committed yet, but it might indent the Discussion Settings options with the same ruleset.
Note: See TracTickets for help on using tickets.