Opened 5 months ago
Closed 5 months ago
#61553 closed defect (bug) (fixed)
Section Styles: Prevent flash of block style variation styling in post editor
Reported by: | aaronrobertshaw | Owned by: | davidbaumwald |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | 6.6 |
Component: | Editor | Keywords: | gutenberg-merge has-patch dev-reviewed |
Focuses: | Cc: |
Description
This ticket tracks the backport of PHP files for the following Gutenberg updates:
These changes prevent a flash of style updates for applied block style variations when the global styles data is loaded into the block editor. This is done by preloading the global styles REST API paths which also brings the post and site editors further into line.
Change History (10)
This ticket was mentioned in PR #6959 on WordPress/wordpress-develop by @aaronrobertshaw.
5 months ago
#1
- Keywords has-patch added
@aaronrobertshaw commented on PR #6959:
5 months ago
#2
I do still see a much briefer flash, but I assume that because a package update is needed to bring the JS changes from https://github.com/WordPress/gutenberg/pull/63071. It's still better than in trunk.
That would be correct. Without the JS update, the global styles ID is loaded after another API request which isn't required when the ID is in the URL already.
The demo videos in the description illustrate the degree to which this is an improvement even without the JS update.
@bgardner commented on PR #6959:
5 months ago
#3
Would love to see this merged prior to RC3 release. Think it is possible?
#5
@
5 months ago
- Keywords dev-feedback added; commit removed
As mentioned on the PR, the changes look good to me.
Would appreciate a second committer approval for 6.6.
The process outlined in this post mentions using dev-feedback
for second committer approval, so I've updated the keywords accordingly.
#6
@
5 months ago
- Resolution set to fixed
- Status changed from new to closed
Apologies, I got confused between the tickets. [58690] fixed this ticket, not the linked one.
#8
@
5 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening this ticket for 2nd committer review and sign-off for backporting [58690] to the 6.6 branch.
This PR backports the changes from https://github.com/WordPress/gutenberg/pull/63071
These changes include preloading the global styles REST API paths required to collect the global styles data for use in the block editor. This has two benefits:
#### Test Instructions
Trac ticket: https://core.trac.wordpress.org/ticket/61553