Make WordPress Core

Opened 8 months ago

Closed 4 months ago

Last modified 4 months ago

#61564 closed task (blessed) (fixed)

GitHub Actions updates and improvements for 6.7

Reported by: desrosj's profile desrosj Owned by:
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

This ticket is for various updates and improvements for Core's GitHub Actions workflows.

Previously:

Change History (17)

#1 @desrosj
7 months ago

In 58754:

Build/Test Tools: Remove regular 6.2 & 6.3 branch performance testing.

Prior to WordPress 6.4, performance testing was performed using Puppeteer instead of Playwright (converted in [56926]). Because of the flaky nature of the workflow using Puppeteer, it was not converted to the reusable pattern implemented through #61213. It was instead removed from 6.2 and 6.3 in [58301] and [58330], respectively.

This removes the workflow for these branches from the strategy matrix when testing old branches to avoid errors and adds an expanded note about why those branches are missing.

See #61213, #61564.

#2 @desrosj
7 months ago

In 58789:

Build/Test Tools: Update third-party GitHub Actions.

The following third-party actions have been updated to their latest versions.

  • shivammathur/setup-php from 2.30.0 to 2.31.1.
  • actions/setup-node from 4.0.2 to 4.0.3.
  • actions/cache from 4.0.1 to 4.0.2.
  • actions/upload-artifact from 4.3.1 to 4.3.4.
  • slackapi/slack-github-action from 1.25.0 to 1.26.0.
  • codecov/codecov-action from 4.1.0 to 4.5.0.

See #61564.

This ticket was mentioned in PR #7368 on WordPress/wordpress-develop by @jrf.


5 months ago
#3

  • Keywords has-patch added

These test jobs should not be run on forks (by default).

Trac ticket: https://core.trac.wordpress.org/ticket/61564

#4 @jrf
5 months ago

  • Keywords has-patch removed

I've opened GH #7368 with a minor tweak.

#5 @desrosj
5 months ago

In 59049:

Build/Test Tools: Submit host test results for each PHP version.

The WordPress Hosting Test Results now supports multiple reports for the same commit from the same test bot. This updates the PHPUnit test workflow to submit results for each version of PHP running the tests.

Props swissspidy, jorbin, crixu, kirasong, desrosj.
See #61564.

#6 @desrosj
5 months ago

In 59167:

Build/Test Tools: Limit when install testing runs.

In most cases, running the installation testing workflow in forked repositories is unnecessary and wasteful. This adds conditions to that workflow to prevent the tests from running on forks unless a pull request is being made back to that fork.

This pattern is already used across other workflows.

Props jrf.
See #61564.

This ticket was mentioned in PR #7390 on WordPress/wordpress-develop by @desrosj.


5 months ago
#8

  • Keywords has-patch added

#10 @desrosj
4 months ago

In 59208:

Build/Test Tools: Update 3rd-party GitHub Actions.

This applies several updates to the following 3rd-party GitHub Actions:

  • actions/setup-node
  • actions/cache
  • actions/upload-artifact
  • slackapi/slack-github-action
  • codecov/codecov-action.

See #61564.

#11 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

I'm going to close this out after [59208]. But if there's any need to make more changes before RC, this can be reopened.

This ticket was mentioned in PR #7588 on WordPress/wordpress-develop by @desrosj.


4 months ago
#12

Workflows with path filtering do not need to run when other workflow files are edited.

Trac ticket: https://core.trac.wordpress.org/ticket/61564

#13 @desrosj
4 months ago

[59251] should have referenced this ticket.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 months ago

#15 @desrosj
4 months ago

In 59252:

Build/Test Tools: Refine paths filter for workflows.

Some GitHub Action workflows use the paths filter to limit when workflows run for pull requests. This helps avoid running workflows unnecessarily when the pull request does not change any relevant code.

Currently, a few of these workflows are configured to run when any .yml file in the .github/workflows/ directory is changed. This updates those workflows to target more specific workflow files for more efficient running.

See #61564.

#17 @desrosj
4 months ago

In 59254:

Build/Test Tools: Refine paths filter for workflows part 2.

[59252] made the path filtering a bit too broad for the Test Old Branches workflow.

Though v3 of the reusable PHPUnit workflow is used by some older branches, this version is updated much more frequently because it’s the latest version.

To limit the number of times this workflow runs, old branches should only be tested when old versions of the workflow are updated.

Follow up to [59252].

See #61564.

Note: See TracTickets for help on using tickets.