Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61567 closed defect (bug) (fixed)

Remove Trac ticket reminder from PR when one is added

Reported by: desrosj Owned by: desrosj
Priority: normal Milestone: 6.7
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

#60129/[58092] added logic to comment on a PR to wordpress-develop when no Trac ticket URL is included (which is required).

When the PR is updated to include one, the comment should be removed to help limit the number of bot comments on a pull request.

Props @ocean90 for the suggestion.

Change History (6)

#1 @debarghyabanerjee
2 years ago

  • Keywords has-patch added; needs-patch removed

#2 @desrosj
2 years ago

  • Keywords changes-requested added

@debarghyabanerjee commented on PR #7009:


2 years ago
#3

Hi @desrosj, I have addressed the feedback and made the changes. I have also added the synchronize, reopened, & edited in the pull_request_track

#4 @desrosj
2 years ago

  • Keywords changes-requested removed
  • Owner set to desrosj
  • Status newreviewing

#5 @desrosj
2 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 59169:

Build/Test Tools: Clean up PR comments after action is taken.

There’s now a number of automated comments left on pull requests to help contributors that a PR can easily be overridden with activity.

Some of the comments are only relevant until a specific action is taken. One such comment is for informing the PR author that a link to a Trac ticket is a requirement for considering any suggested changes.

This updates the pull request comment workflow to remove the comment once a link to a Trac ticket is properly included.

Props debarghyabanerjee.
Fixes #61567.

Note: See TracTickets for help on using tickets.