Opened 2 months ago
Last modified 2 months ago
#61573 new task (blessed)
Tests: Reduce usage of assertEquals for 6.7
Reported by: | SergeyBiryukov | Owned by: | |
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Follow-up to:
- #60706 (6.6)
- #59655 (6.5)
- #58956 (6.4)
- #57855 (6.3)
- #56800 (6.2)
- #55654 (6.1)
- #54726 (6.0)
- #53364 (5.9)
- #52482 (5.8)
- #38266 (5.7)
The assertEquals()
test method does not check that the types of the expected and actual values match. This can hide subtle bugs especially when the values are falsey.
Tasks:
- Switch to using
assertSame()
when the type of the value in the assertion is important - Replace overall usage of
assertEquals()
with type-strict assertion methods, with the aim of potentially removing its usage altogether
To help ease the effort of merging tests, changes should also be made upstream in the Gutenberg repository.
Change History (2)
Note: See
TracTickets for help on using
tickets.
This PR replaces
assertEquals()
with more appropriate, stricter assertions where possible and without making any changes to source.For easier reviewing, commits have been separated based on the replacement assertion and any additional changes required to implement the stricter assertion.
Trac ticket: https://core.trac.wordpress.org/ticket/61573
Trac ticket: https://core.trac.wordpress.org/ticket/60706
Trac ticket: https://core.trac.wordpress.org/ticket/59655
Trac ticket: https://core.trac.wordpress.org/ticket/55654