Make WordPress Core

Opened 8 months ago

Closed 4 months ago

#61573 closed task (blessed) (fixed)

Tests: Reduce usage of assertEquals for 6.7

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

Follow-up to:

The assertEquals() test method does not check that the types of the expected and actual values match. This can hide subtle bugs especially when the values are falsey.

Tasks:

  • Switch to using assertSame() when the type of the value in the assertion is important
  • Replace overall usage of assertEquals() with type-strict assertion methods, with the aim of potentially removing its usage altogether

To help ease the effort of merging tests, changes should also be made upstream in the Gutenberg repository.

Change History (4)

This ticket was mentioned in PR #1768 on WordPress/wordpress-develop by @costdev.


8 months ago
#1

  • Keywords has-patch has-unit-tests added

This PR replaces assertEquals() with more appropriate, stricter assertions where possible and without making any changes to source.

For easier reviewing, commits have been separated based on the replacement assertion and any additional changes required to implement the stricter assertion.

Trac ticket: https://core.trac.wordpress.org/ticket/61573
Trac ticket: https://core.trac.wordpress.org/ticket/60706
Trac ticket: https://core.trac.wordpress.org/ticket/59655
Trac ticket: https://core.trac.wordpress.org/ticket/55654

#2 @SergeyBiryukov
8 months ago

In 58673:

Tests: Use assertSame() in WP_REST_Global_Styles_Revisions_Controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [56082].

See #61573.

This ticket was mentioned in Slack in #core by chaion07. View the logs.


4 months ago

#4 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

With RC1 due out in a few hours, I'm going to close this out. I've created #62278 to continue in 6.8.

Note: See TracTickets for help on using tickets.