Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#6163 closed defect (bug) (fixed)

View Site link shouldn't force link to open in a new window

Reported by: Denis-de-Bernardy Owned by: matt
Milestone: 2.5 Priority: low
Severity: trivial Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description (last modified by lloydbudd)

View Site link in admin area opens the link in a new tab/window. kind of annoying... :(

I'm assuming there was some kind of discussion regarding this. I'm opening a ticket in case there wasn't. I personally vote for reverting to the previous (same window/tab) behavior.

Attachments (2)

6163.patch (1000 bytes) - added by Viper007Bond 8 years ago.
6163-2.patch (1.7 KB) - added by Viper007Bond 8 years ago.
Found another one

Download all attachments as: .zip

Change History (15)

comment:1 @markjaquith8 years ago

I'm also not a fan of things deciding that they know how you want to manage your tabs/windows.

comment:2 @christhomson8 years ago

I agree, it's really not a great idea having it open in a new window/tab. If the user wants to open it in a new window/tab, they could use the keyboard shortcut (or right clicking) to do that.

comment:3 @ryan8 years ago

  • Owner changed from anonymous to matt

Changed in [7230] by that Matt guy. Assigning to him.

comment:4 @lloydbudd8 years ago

  • Description modified (diff)
  • Summary changed from View Site link in admin area to View Site link shouldn't force link to open in a new window

comment:5 @MichaelH8 years ago

Reasons for not opening View Site in a new window/new tab:

  • It's not done that before.
  • No other link in the admin UI works like that. Wouldn't you want other links like to Help, Forums, WordPress, Documentation, Feedback, as well as links to Plugin authors, Theme authors, and any other links to Codex, to react in the same manner?
  • So you View Site, don't like what you see, and press the Site Admin link and then you've got two tabs in the admin section.

comment:6 @Viper007Bond8 years ago

Agreed. If I want it to open in a new tab, I can middle click or shift click.

Really annoying.

comment:7 @helmi8 years ago

Blogs (and isn't WordPress a synonym for that *g*) started to revert this silly _blank culture and should definitely not stop it like this.

++ for a no-target-link for "view site"

comment:8 @matt8 years ago

  • Status changed from new to assigned

There are other places in WP that do this, bonus points if you find them.

comment:9 @DD328 years ago

There are other places in WP that do this, bonus points if you find them.

Oh, C'mon, give us a challenge!

grep -r -s target= * | grep -v .svn | grep -v wp-content

..Maybe even tack on | grep -v /js/ :P

But yes indeed, While i usually use that link to open in a background tab, I manually specify for it to do that, i expect it to load in the current window otherwise..

@Viper007Bond8 years ago

comment:10 @Viper007Bond8 years ago

  • Keywords has-patch added

I dunno about any others (I can't grep), but there's a patch to remove the "View Site" one.

comment:11 @Denis-de-Bernardy8 years ago

will this get fixed before the actual release? it's really annoying... :(

@Viper007Bond8 years ago

Found another one

comment:12 @markjaquith8 years ago

If not on general principle, then for this specific case: unlike a Preview link, the clicking of the "View Site" link implies a relatively permanent exit from the admin (transition from managing your site to using it), and thus it is reasonable for it to open in the same window/tab.

comment:13 @markjaquith8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7522]) Consensus is to make "Visit Site" links open in the same tab/window. fixes #6163

Note: See TracTickets for help on using tickets.