WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#61635 closed defect (bug) (fixed)

Group block inner container should be removed when Grid variation is active in classic themes

Reported by: isabel_brison Owned by:
Priority: normal Milestone: 6.7
Component: Editor Version: 6.6
Severity: normal Keywords: gutenberg-merge has-patch commit
Cc: Focuses:

Description

Grid blocks shouldn't have an inner container in classic themes, because some themes attach styles to that container that can cause the grid layout to break. This was fixed in Gutenberg while grid was still experimental, but the PR never got synced to core: ​https://github.com/WordPress/gutenberg/pull/49387

Change History (9)

This ticket was mentioned in ​PR #7016 on ​WordPress/wordpress-develop by ​@isabel_brison.
2 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/61635

Syncs ​https://github.com/WordPress/gutenberg/pull/49387 to core.

Testing in TT1, a grid that looks like this in the editor:

https://github.com/user-attachments/assets/6754beb4-ae18-4d56-bc5d-37f329d1b499

Should now look like this in the front end:

https://github.com/user-attachments/assets/dbd46a6c-08f4-481f-82bd-54de572ac809

Instead of looking like this:

https://github.com/user-attachments/assets/a32828d2-df12-45b0-a5dd-6b94699ae7e0

The remaining discrepancy between editor and front end is due to a pseudo-element that TT1 inserts into all Group blocks. There's a fix for that open in #7001.

#2 @isabel_brison
2 years ago

In 58708:

Editor: remove Group inner container from Grid variation in classic themes.

Updates the logic in the layout filter that replaces the Group block inner container in classic themes to exclude the Grid variation.

Props isabel_brison, aaronrobertshaw, andrewserong.
See #61635.

#3 @isabel_brison
2 years ago

  • Keywords dev-feedback added

Cc @ellatrix would be good to add this in 6.6.1.

​@isabel_brison commented on ​PR #7016:
2 years ago #4

Thanks for the reviews! Committed to trunk in r58708.

#5 @ellatrix
2 years ago

Ok, thanks for leaving it open, it should get picked up then.

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
2 years ago

#7 @hellofromTonya
2 years ago

Was this bug introduced in the 6.6 cycle? Or is fixing an earlier bug?

If in the 6.6 cycle, then it make sense to include in 6.6.1. If earlier than 6.6, what is the impact to drive including it in 6.6.1?

cc @ellatrix

#8 @hellofromTonya
2 years ago

  • Milestone 6.6.1 → 6.6.2

With 6.6.1 RC happening soon today, moving this one to 6.6.2, though still need to confirm thisi is to fix a bug introduced in the 6.6 cycle.

#9 @hellofromTonya
2 years ago

  • Keywords commit added; dev-feedback removed
  • Milestone 6.6.2 → 6.7
  • Resolution → fixed
  • Status new → closed

When was this bug introduced?

The ​Gutenberg PR that fixes it is from March 2023. The bug was introduced in WordPress 6.2 or 6.3 cycle.

As the bug was not introduced during the 6.6 cycle, moving it to 6.7 and reclosing as fixed.

That said, could reconsider if this bugfix is impacting a feature introduced in 6.6.

Note: See TracTickets for help on using tickets.