links are now underlined

[Annubis]

after update to wordpress 6.6 all links are now underlined.

[joedolson]

Please add some context to this; we'll need to know something about where you're seeing unexpected underlines to be able to act on this in any way. It seems unlikely that this belongs in the Permalinks component, but without any context, it's hard to say.

[butterflymedia]

I have already opened a ticket on the block editor on GitHub, and they said there is a hotfix for 6.6.1. Here is the link - ​https://github.com/WordPress/gutenberg/issues/63345

Still, there is a bunch of :root and :where styles overriding everything. Another example would be all centred images are now left aligned.

Regarding the underline, their reply was that this is common behaviour for browsers to underline links…

Here is the selector being added by the core:

:root :where(a:where(:not(.wp-element-button))) {
    text-decoration: underline;
}

[swissspidy]

Closing as reported-upstream as this was reported & fixed in Gutenberg and should be resolved in WP 6.6.1.

[swissspidy]

#61661 was marked as a duplicate.

[butterflymedia]

This is how I solved it, in case anyone stumbles upon this ticket. I put the code below in my theme:

:root :where(a:where(:not(.wp-block-navigation))),
:root :where(a:where(:not(.wp-element-button))) {
    text-decoration: initial;
}

[Annubis]

Replying to joedolson:

Please add some context to this; we'll need to know something about where you're seeing unexpected underlines to be able to act on this in any way. It seems unlikely that this belongs in the Permalinks component, but without any context, it's hard to say.

i saw this after i updated my wordpress projects - i use gutenberg and divi and other themes and this happens after the update. for me this means that it is not a theme bug

why? i dont know - I thought this was a wp update bug and wanted to report it.

sorry, this was my first ticket i started and i haven't seen any others with this topic before

[joedolson]

#61663 was marked as a duplicate.

[joedolson]

@annubis The kind of context that's relevant are things like "where on your site are you seeing this?" Based on what you initially reported, I wouldn't even know that this was an issue on the front-end vs the back-end. A screenshot showing an example of the issue is always helpful. Opening an issue is a perfectly good response to seeing something unexpected! We just need to know a bit more about what you're seeing and where to be able to move forward.

[hellofromTonya]

Also reported in the WordPress Support forum ​https://wordpress.org/support/topic/6-6-update-caused-underline-on-all-links/.

[hellofromTonya]

Though this has been reported ​upstream and a ​patch merged into Gutenberg, thinking it might be better to reopen and milestone this Trac ticket for tracking and testing purposes.

Assuming the Gutenberg patch resolves it, this Trac ticket will then be closed as fixed by the package updates commit.

[andrewserong]

Assuming the Gutenberg patch resolves it, this Trac ticket will then be closed as fixed by the package updates commit.

It looks like it'll also need this backport PR to be committed: ​https://github.com/WordPress/wordpress-develop/pull/7012

Also logged in this trac ticket: https://core.trac.wordpress.org/ticket/61630

[aaronrobertshaw]

Replying to butterflymedia:

This is how I solved it, in case anyone stumbles upon this ticket. I put the code below in my theme:

:root :where(a:where(:not(.wp-block-navigation))),
:root :where(a:where(:not(.wp-element-button))) {
    text-decoration: initial;
}

An alternative to the above change would be to ensure that somewhere in the CSS selectors for links there is a classname or class-level selector.

A discussion around such a temporary fix can be found in ​https://github.com/WordPress/gutenberg/issues/63345#issuecomment-2224249574

i use gutenberg and divi and other themes and this happens after the update. for me this means that it is not a theme bug

The fix for this issue in ​https://github.com/WordPress/gutenberg/pull/63403 will be available in GB 18.8 which should be released today.

[jorbin]

To make it easier to test, a small group of us (in the thread shared above) have created a ​version of the Gutenberg Plugin that you can install. This plugin should be equal to what was shipped in WordPress 6.6 with ​one additional fix. This testing method is assuming that you do not have the Gutenberg plugin already activated on your site. If you do, please wait for Gutenberg 18.8 coming later today. A few additional notes:

1. This is the first time we are trying this method of testing a fix, so it's possible there are some side effects. As always, you are encouraged to test on a staging site or locally if at all possible.

2. Due to this novel testing method, this version of GB has a version number that is in the past. Please don't upgrade Gutenberg even though you will immediately be notified that a new version is available

[hellofromTonya]

Multiple reports in the ​same support forum request.

​Pointed users here, asking them to test using the test plugin on the affected sites.

[hellofromTonya]

For those testing the proposed fix (using the test plugin), here's more information to help:

This test plugin is available for you to test if the proposed fix (which is in the plugin) resolves the issue.

Replying to jorbin:

To make it easier to test, a small group of us (in the thread shared above) have created a ​version of the Gutenberg Plugin that you can install. This plugin should be equal to what was shipped in WordPress 6.6 with ​one additional fix. This testing method is assuming that you do not have the Gutenberg plugin already activated on your site. If you do, please wait for Gutenberg 18.8 coming later today. A few additional notes:

1. This is the first time we are trying this method of testing a fix, so it's possible there are some side effects. As always, you are encouraged to test on a staging site or locally if at all possible.

2. Due to this novel testing method, this version of GB has a version number that is in the past. Please don't upgrade Gutenberg even though you will immediately be notified that a new version is available

On sites that do not already have the Gutenberg plugin installed, here are the testing steps:

1. Download the plugin.
2. Unzip it.
3. Install the plugin zip file into the affected site (preferably in a local or staged environment).
4. Activate the plugin.
5. Go to or refresh the frontend.
6. Note if the underline issue is resolved or not.
7. Deactivate and delete the plugin.
8. Report findings here.

On sites that do have the Gutenberg plugin installed, please use these steps:

1. Go to Plugins.
2. Check the version of the Gutenberg plugin. If not version 18.8, please upgrade it.
3. Make sure the plugin is activated.
4. Go to or refresh the frontend.
5. Note if the underline issue is resolved or not.
6. Report findings here.

[jchambo]

When can we expect an update to revert this?

[jorbin]

@jchambo as of now, the team is exploring ​https://github.com/WordPress/gutenberg/pull/63403 as a fix. Can you follow the testing instructions in mine and @hellofromTonya's comments above and report back if it resolves it for you?

[jchambo]

Replying to jorbin:

@jchambo as of now, the team is exploring ​https://github.com/WordPress/gutenberg/pull/63403 as a fix. Can you follow the testing instructions in mine and @hellofromTonya's comments above and report back if it resolves it for you?

This solves my issue when using Divi via inputting it in the CSS:

/*Fix WordPress v6.6 Underline Text Issue*/
:root a:not(.wp-element-button) {
text-decoration: none;
}

[hellofromTonya]

@jasko40 tested the testing plugin and confirmed all links are no longer underlined. Coping the their post here.

​https://wordpress.org/support/topic/6-6-update-caused-underline-on-all-links/#post-17896314

Before state:

Before testing 18.5.0-rc.1 , all text links, button links with text in them, and menu links were all underlined.

After installing/activating the test plugin with the fix:

I was able to test the supplied Gutenburg plugin test (vers 18.5.0-rc.1). After install the underlining issue appears to be fixed! I’m also not currently noticing any new problems created by it yet.

[hellofromTonya]

Replying to jchambo:

This solves my issue when using Divi via inputting it in the CSS:

/*Fix WordPress v6.6 Underline Text Issue*/
:root a:not(.wp-element-button) {
text-decoration: none;
}

Hello @jchambo, are you able to test using the test plugin without the CSS workaround?

[hellofromTonya]

Props to @raquelandefeld for lending me up a testing version of the Divi theme.

Test Report

Patch tested: ​used version of the Gutenberg plugin which included the fix.

Environment

• WordPress: 6.6.0
• Browser: Firefox v 128.0 and Edge v 126.0.2592.102
• PHP: 8.3
• Web server: nginx
• Theme: Divi v 4.26.1
• Plugins: Test plugin

Steps to Reproduce or Test

1. Install and active the Divi theme.
2. Refresh the frontend.
3. 🐞 Observe all links are underlined.
4. Install and activate the test plugin.
5. Refresh the frontend.
6. ✅ Observe the links are no longer underlined.

Actual Results

Before activating the test plugin:

• ❌ Error condition occurs. (Can reproduce it)

After activating the test plugin:

• ✅ Issue is resolve and no noticeable side effects.

[hellofromTonya]

Test Report: Can reproduce the issue. Shows the underlined links before activating the test plugin.

[hellofromTonya]

Test Report: Issue resolved (no link underlines) after activating the test plugin (with the fix).

[hellofromTonya]

Test Report: With fix applied, side-by-side comparison of 6.5.5 and 6.6 with the fix (via the test plugin).

[hellofromTonya]

Test Report: side-by-side comparison of 6.5.5 and 6.6.0 (without the fix)

[Annubis]

Replying to jorbin:

To make it easier to test, a small group of us (in the thread shared above) have created a ​version of the Gutenberg Plugin that you can install. This plugin should be equal to what was shipped in WordPress 6.6 with ​one additional fix. This testing method is assuming that you do not have the Gutenberg plugin already activated on your site. If you do, please wait for Gutenberg 18.8 coming later today. A few additional notes:

1. This is the first time we are trying this method of testing a fix, so it's possible there are some side effects. As always, you are encouraged to test on a staging site or locally if at all possible.

2. Due to this novel testing method, this version of GB has a version number that is in the past. Please don't upgrade Gutenberg even though you will immediately be notified that a new version is available

yes i can confirm this "gutenberg.zip" plugin solutions works. after plugin activation the underline are gone

[Annubis]

Replying to joedolson:

@annubis The kind of context that's relevant are things like "where on your site are you seeing this?" Based on what you initially reported, I wouldn't even know that this was an issue on the front-end vs the back-end. A screenshot showing an example of the issue is always helpful. Opening an issue is a perfectly good response to seeing something unexpected! We just need to know a bit more about what you're seeing and where to be able to move forward.

thanks for a light criticism - you're absolutely right. i'll go into more detail next time i report something. sorry and thanks

[clarktbt]

I just tried the Gutenberg plugin in one of my Divi sites that has just upgraded to WP 6.6 and is exhibiting the underline issue. After installing the plugin, the site reverts back to how it was meant to look, without underlines on links.

I haven't been systematic (sorry) but I don't remember any of my Divi websites that have gone to WP 6.6 so far not showing unwanted underlines. I see it in embedded (in text) links, in Divi button modules and I also see underlines on mobile menu items, at least I do when just using Chrome Inspect to look at them. I haven't seen this last example mentioned elsewhere. The plugin fixes all of these, including the mobile menu underlines.

I manage a lot of Divi websites. The ones that have already gone to WP 6.6, I've 'fixed' by adding CSS myself to set text-decoration:none as appropriate. A better and more general fix would be great, thank you. I really appreciate how quickly this is being looked at.

[hellofromTonya]

Replying to clarktbt:

I just tried the Gutenberg plugin in one of my Divi sites that has just upgraded to WP 6.6 and is exhibiting the underline issue. After installing the plugin, the site reverts back to how it was meant to look, without underlines on links.

I haven't been systematic (sorry) but I don't remember any of my Divi websites that have gone to WP 6.6 so far not showing unwanted underlines. I see it in embedded (in text) links, in Divi button modules and I also see underlines on mobile menu items, at least I do when just using Chrome Inspect to look at them. I haven't seen this last example mentioned elsewhere. The plugin fixes all of these, including the mobile menu underlines.

Thank you for testing and validating it works on your affected site.

[hellofromTonya]

Elevating the priority to high for better tracking, as this issue is one of the drivers for a faster 6.6.1.

[noisysocks]

In 58749:

Block Themes: Avoid specificity bump for top-level element-only selectors

Prevent issues (e.g. links being underlined) caused by a bump in CSS
specificity for top-level element-only global element styles.

Backports the PHP changes from ​https://github.com/WordPress/gutenberg/pull/63403.

Fixes #61630.
Fixes #61660.
Props aaronrobertshaw, andrewserong, noisysocks.

[noisysocks]

Reopening to request backporting r58749 to the 6.6 branch.

[noisysocks]

#61630 was marked as a duplicate.

[andrewserong]

I've reviewed the change in https://core.trac.wordpress.org/changeset/58749, so just marking this as dev-reviewed for commit to the 6.6 branch.

[butterflymedia]

Will all these :root and :where styles be removed in 6.6.1? That would be great.

[butterflymedia]

The filter below fixed the entire issue for me:

add_action(
    'wp_head',
    function () {
    	global $wp_styles;

        if ( ! empty( $wp_styles->registered['global-styles']->extra['after'][0] ) ){
    		$wp_styles->registered['global-styles']->extra['after'][0] = str_replace(
                [
                    ':root :where',
                    ':root',
                    ':where',
                ],
                '',
                $wp_styles->registered['global-styles']->extra['after'][0]
            );
        }
    },
    1
);

[hellofromTonya]

[58749] props need adjustment to include everyone who reported and tested the issue. I'll manually adjust its props and then update the list of props when doing the backport commit to the 6.6 branch.

Setting myself for backport review and commit.

[hellofromTonya]

Tested [58749] on the 6.6 branch using the same approach previously done in my test report with the Divi theme. Before the changeset, all links are underlined. After the changeset, issue is resolved.

Gathering additional props.
Then will backport to the 6.6 branch.

[hellofromTonya]

In 58751:

Block Themes: Avoid specificity bump for top-level element-only selectors.

Prevent issues (e.g. links being underlined) caused by a bump in CSS specificity for top-level element-only global element styles.

Ref: PHP changes from ​https://github.com/WordPress/gutenberg/pull/63403.

Reviewed by hellofromTonya.
Merges [58749] to the 6.6 branch.

Props aaronrobertshaw, andrewserong, noisysocks, annubis, butterflymedia, clarktbt, hellofromTonya, jorbin, joedolson, swissspidy, courane01, raquelandefeld, talldanwp, markhowellsmead, youknowriad, poena, cbirdsong.
Fixes #61630, #61660.

[hellofromTonya]

In 58757:

Editor: Update packages for 6.6.1.

Bugfixes included:

• ​Elements: Avoid specificity bump for top-level element-only selectors.
• ​Navigation block: Allow themes to override block library text-decoration rule.
• ​Fix invalid css for nested fullwidth layouts with zero padding applied.
• ​Prevent empty void at the bottom of editor when block directory results are present.
• ​Pattern overrides: Ensure "Reset" button always shows as last item and with border.
• ​Global Styles: Disable "Reset styles" button when there are no changes.
• ​Fix: Removed shuffle button when only 1 pattern is present.
• ​fix: wp icon focus issue.
• ​useBlockElement: return null until ref callback has time to clean up the old element.

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.

[hellofromTonya]

In 58760:

Editor: Update packages for 6.6.1.

Bugfixes included:

• ​Elements: Avoid specificity bump for top-level element-only selectors.
• ​Navigation block: Allow themes to override block library text-decoration rule.
• ​Fix invalid css for nested fullwidth layouts with zero padding applied.
• ​Prevent empty void at the bottom of editor when block directory results are present.
• ​Pattern overrides: Ensure "Reset" button always shows as last item and with border.
• ​Global Styles: Disable "Reset styles" button when there are no changes.
• ​Fix: Removed shuffle button when only 1 pattern is present.
• ​fix: wp icon focus issue.
• ​useBlockElement: return null until ref callback has time to clean up the old element.

Reviewed by spacedmonkey.
Merges [58757] to the 6.6 branch.

Props ellatrix.
Fixes #61692.
See #61660, #61630, #61656.