Update the `$_old_files` array for 6.6

[dd32]

It doesn't appear that the $_old_files array was updated prior to the 6.6 release.

The following files need to be added:

$ svn diff --summarize https://core.svn.wordpress.org/tags/6.5 https://core.svn.wordpress.org/tags/6.6 | grep '^D'
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor.min.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor-rtl.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor-rtl.min.css

See ​https://make.wordpress.org/core/handbook/about/release-cycle/releasing-major-versions/#dry-run

[dd32]

Just noting, that has caused a number of "security plugins" to throw warnings about the WordPress installation having extra unexpected files.

[audrasjb]

Erf. When preparing the Dry Run we saw those files with @davidbaumwald and @hellofromTonya but assumed they were false positive. Sorry everyone about that.
​https://wordpress.slack.com/archives/C06U06K50Q5/p1720968264541949

[hellofromTonya]

Are these actually old files? Or are they artifacts causing false flags?

Copying parts of the ​slack discussion about these particular files:

@davidbaumwald observed these files keep getting reported for "a few majors":

^D produce a few false positives that have existed for a while now, and ^A reports things that do not exist in the array previously.
...
They've been there for a few majors now

and was working with systems to help identify why:

I reached out to systems to see if there's some sort of artifact in core.svn.wordpress.org

Hey @davidbaumwald, any feedback from the systems team?

[hellofromTonya]

Are these actually old files? Or are they artifacts causing false flags?

I compared 6.4.5, 6.5.5, and 6.6.0 to find out.

The files:

'wp-includes/blocks/block/editor.css',
'wp-includes/blocks/block/editor.min.css',
'wp-includes/blocks/block/editor-rtl.css',
'wp-includes/blocks/block/editor-rtl.min.css',

How:

1. Downloaded each version from ​the release archives.
2. Unzipped each, renaming the directory to append its version.
3. Navigated to wp-includes/blocks/block/ directory in each version to check if the files were there or not.

Results:

• 6.4.5 ✅ yes these files are present.
• 6.5.5 ✅ yes these files are present.
• 6.6.0 ❌ no these files are not present.

Interesting. So they were removed in the 6.6 cycle.

[davidbaumwald]

I understand now. These are built files, and only exist after a build, which core.svn.wordpress.org seems to be referencing the build repo(currently at rev 58145).

The $_old_files should include them. This is on me for conflating two different issues in the past.

Going to get this committed to trunk now.

Adds the following files to the $_old_files array for 6.6:

$ svn diff --summarize https://core.svn.wordpress.org/tags/6.5 https://core.svn.wordpress.org/tags/6.6 | grep '^D'
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor.min.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor-rtl.css
D       https://core.svn.wordpress.org/tags/6.5/wp-includes/blocks/block/editor-rtl.min.css

Originally flagged as false positives, these specific files did exist in 6.4.5 and 6.5.5, but no longer exist in 6.6.

Trac ticket: https://core.trac.wordpress.org/ticket/61665

Missed during the Dry Run(by me).

[davidbaumwald]

In 58744:

Upgrade/Install: Update the $_old_files array for 6.6.

Props dd32, audrasjb, hellofromTonya.
Fixes #61665.

Closing in favor of patch with same changes that was committed in https://core.trac.wordpress.org/changeset/58744.

[davidbaumwald]

Reopening for backport to the 6.6 branch.

[hellofromTonya]

[58744] LGTM for backport to the 6.6-branch.

[joedolson]

#61678 was marked as a duplicate.

[hellofromTonya]

backporting now.

[hellofromTonya]

In 58746:

Upgrade/Install: Update the $_old_files array for 6.6.

Reviewed by hellofromTonya.
Merges [58744] to the 6.6 branch.

Props dd32, audrasjb, hellofromTonya.
Fixes #61665.

[hellofromTonya]

Manually added @jpnl to the commit props, i.e. who reported the same issue in #61678.

[generosus]

Hey Guys!

Thanks for jumping on this so quickly.

Are you going to release a WP patch (say, V 6.6.1) to close this finding?

Cheers!

[jorbin]

@generosus RC1 for 6.6.1 was ​made available yesterday and assuming there are no issues, it is planned to be released on ​23 July

[generosus]

@jorbin Perfect. Thank you!