Make WordPress Core

Opened 3 months ago

Last modified 3 months ago

#61666 new enhancement

Extra margin in tablet and mobile login button in admin login

Reported by: trushaamin's profile trushaamin Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 3.8
Component: Login and Registration Keywords: needs-design-feedback has-patch changes-requested 2nd-opinion
Focuses: ui, css Cc:

Description

I have just found one issue in admin login there is an extra margin of 4px from the bottom-side of the login button on mobile and tablet.

Attachments (2)

Login issue.png (30.1 KB) - added by trushaamin 3 months ago.
61666.diff (393 bytes) - added by modi2918 3 months ago.
Patch file for solution

Download all attachments as: .zip

Change History (7)

#1 @deeppatel8950
3 months ago

Same issue with the button margin on responsive devices.

@modi2918
3 months ago

Patch file for solution

#2 @modi2918
3 months ago

  • Component changed from Administration to Login and Registration

#3 follow-up: @sabernhardt
3 months ago

  • Keywords has-patch changes-requested 2nd-opinion added; needs-patch removed
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement
  • Version changed from 6.6 to 3.8

Hi and thanks for the report!

Editing the buttons.css styles can affect many other parts of the admin UI, so that stylesheet needs to keep the margin (which was originally added in [26134]).

It might be worth setting the .login .submit .button bottom margin to zero for most uses of wp-login.php. I was most concerned about the password-reset form, but both the Generate Password and Save Password buttons have their own 6-pixel bottom margin to give space between them when stacked vertically.

#4 @dharmik1455
3 months ago

There is no need for a 4px bottom margin on this button. Upon removing the 4px margin, the design remains intact. I have checked the design and everything looks good.

#5 in reply to: ↑ 3 @trushaamin
3 months ago

I think @dharmik1455 is right, when we remove the 4px margin after no any design break. sabernhardt:

Hi and thanks for the report!

Editing the buttons.css styles can affect many other parts of the admin UI, so that stylesheet needs to keep the margin (which was originally added in [26134]).

It might be worth setting the .login .submit .button bottom margin to zero for most uses of wp-login.php. I was most concerned about the password-reset form, but both the Generate Password and Save Password buttons have their own 6-pixel bottom margin to give space between them when stacked vertically.

Last edited 3 months ago by trushaamin (previous) (diff)
Note: See TracTickets for help on using tickets.