Make WordPress Core

Change History (15)

This ticket was mentioned in PR #7057 on WordPress/wordpress-develop by @ellatrix.


7 months ago
#1

  • Keywords has-patch added

#2 @hellofromTonya
7 months ago

  • Owner set to hellofromTonya
  • Status changed from new to reviewing

#3 @hellofromTonya
7 months ago

  • Keywords commit added

Patch: https://github.com/WordPress/wordpress-develop/pull/7057

✅ Packages and their version changes match https://github.com/WordPress/gutenberg/commit/5c1d6bb774e6f78f0bbd4cdc85c4a7087da2f8a0

✅ Includes all fixes scrubbed earlier today.

✅ Tested locally - nothing in the server logs or browser console.

LGTM for commit ✅

Prepping commit now.

#6 @hellofromTonya
7 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 2nd committer sign-off to backport [58757] to the 6.6 branch for 6.6.1.

#7 follow-up: @spacedmonkey
7 months ago

There are multiple PR that contain PHP code that do not seem to be ported.

Examples
https://github.com/WordPress/gutenberg/pull/63436/
https://github.com/WordPress/gutenberg/pull/63637

Should these changes be manually ported?

@hellofromTonya @ellatrix

#8 in reply to: ↑ 7 @hellofromTonya
7 months ago

Replying to spacedmonkey:

There are multiple PR that contain PHP code that do not seem to be ported.

Examples
https://github.com/WordPress/gutenberg/pull/63436/
https://github.com/WordPress/gutenberg/pull/63637

Should these changes be manually ported?

These were handled in separate tickets (referenced in the See):

Last edited 7 months ago by hellofromTonya (previous) (diff)

#9 @hellofromTonya
7 months ago

Also just double-checked all of the other fixes. Only those 2 mentioned have PHP changes. Are you seeing others @spacedmonkey?

#10 @spacedmonkey
7 months ago

  • Keywords dev-reviewed added; dev-feedback removed

@hellofromTonya I reviewed on the javascript / css changes, they look good. Loaded locally and didn't see any php / javascript errors.

#11 @hellofromTonya
7 months ago

Awesome. Thank you @spacedmonkey

#12 @hellofromTonya
7 months ago

Doing the backport commit now.

#14 @spacedmonkey
7 months ago

Created a follow issue, to make backporting of gutenberg classes easier - #61696

#15 @hellofromTonya
7 months ago

  • Keywords fixed-major added
Note: See TracTickets for help on using tickets.