Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#61697 closed defect (bug) (fixed)

Twenty Thirteen: Code block does not adjust font size with block settings

Reported by: viralsampat Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: css

Description

Hello Team,

I have reviewed "code" block on the twenty thirteen theme and found that the "typography" is not working when we trying to change.

Here, I have provided its video and screenshot:

I think that it should be change based on selection.

Thanks,

Attachments (4)

Screen Recording 2024-07-18 at 10.50.20 PM.mp4 (1.2 MB ) - added by viralsampat 2 years ago.
Issue video:
code-block-editor-side.png (163.6 KB ) - added by viralsampat 2 years ago.
Issue back-end screenshot:
code-block-front-end-side.png (226.5 KB ) - added by viralsampat 2 years ago.
Issue front-end screenshot:
61697.diff (812 bytes ) - added by sabernhardt 2 years ago.
inherits font size when code is inside pre element (the default is 14 pixels for each individual element)

Download all attachments as: .zip

Change History (10)

@viralsampat
2 years ago

Issue back-end screenshot:

@viralsampat
2 years ago

Issue front-end screenshot:

@sabernhardt
2 years ago

inherits font size when code is inside pre element (the default is 14 pixels for each individual element)

#1 @sabernhardt
2 years ago

  • Keywords dev-feedback removed
  • Milestone Awaiting ReviewFuture Release
  • Summary Twenty Thirteen Theme: The code block typography is not working properly on editor & front end sides.Twenty Thirteen: Code block does not adjust font size with block settings

Twenty Thirteen sets 14-pixel font size for both pre and code, so 61697.diff proposes inheriting when the code element is nested inside a pre tag.

That seems cleaner than editing the block-specific styles to inherit the block's size only when either its class or style attribute contains font-size.

#2 @sabernhardt
2 years ago

  • Version 6.6

Related: #61753

#3 @karmatosed
2 years ago

  • Milestone Future Release6.7
  • Owner set to karmatosed
  • Status newassigned

Assigning to myself for testing with possibly committing if that works out.

#4 @karmatosed
2 years ago

  • Resolutionfixed
  • Status assignedclosed

In 58815:

Twenty Thirteen: Fixes Code block not adjusting to font size changes.

This resolves the Code block not changing when the font sizes are switched. This theme uses a 14 px size for both and this uses inherit when nested inside pre tag.

Props viralsampat, sabernhardt.
Fixes #61697.

#5 @karmatosed
2 years ago

  • Keywords commit added

#6 @karmatosed
2 years ago

  • Keywords needs-testing removed
Note: See TracTickets for help on using tickets.