Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#61699 closed defect (bug) (fixed)

Performance workflow cannot find artifact in branches on `workflow_dispatch`

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.6
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

The performance workflow has been failing for branches when triggered using workflow_dispatch since the changes related to #61213.

This seems to be happening due to a lack of a github.event.before property in the event payload for workflow_dispatch, which results in TARGET_SHA being set to an empty value.

Change History (3)

This ticket was mentioned in PR #7058 on WordPress/wordpress-develop by @desrosj.


5 months ago
#1

This attempts to use native git commands to find the preceding commit SHA when one is not provided through GitHub Actions contexts.

Trac ticket: https://core.trac.wordpress.org/ticket/61699

#2 @desrosj
5 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 58767:

Build/Test Tools: Ensure TARGET_SHA is set for older branches.

The workflow_dispatch event payload does not contain the before property containing the previous commit’s SHA value, which causes scheduled runs of the performance testing workflow in older branches to fail.

This adds a step specifically for this event type to use native Git commands to retrieve the required SHA value instead.

Props joemcgill.
Fixes #61699.

Note: See TracTickets for help on using tickets.