Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#61700 closed defect (bug) (fixed)

Twenty Sixteen: correct Code block font family, line-height and padding in the editor

Reported by: viralsampat's profile viralsampat Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing commit
Focuses: css Cc:

Description

Hello Team,

I have reviewed the "code" block and found that its line-height is not same on editor and front-end sides.

I think that is should be same on both(Editor & front-end) sides.

Here, I have provided its screenshots:

Thanks,

Attachments (3)

Screenshot 2024-07-19 at 12.11.18 AM.png (415.0 KB) - added by viralsampat 6 months ago.
Issue back-end screenshot:
Screenshot 2024-07-19 at 12.13.38 AM.png (322.9 KB) - added by viralsampat 6 months ago.
Issue front-end screenshot:
61700.diff (505 bytes) - added by sabernhardt 6 months ago.
adds font-family and line-height values from front-end styles, and corrects the padding

Download all attachments as: .zip

Change History (8)

@viralsampat
6 months ago

Issue back-end screenshot:

@viralsampat
6 months ago

Issue front-end screenshot:

@sabernhardt
6 months ago

adds font-family and line-height values from front-end styles, and corrects the padding

#1 @sabernhardt
6 months ago

  • Component changed from General to Bundled Theme
  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Sixteen: The code block line-height is not same on editor & front-end sides. to Twenty Sixteen: correct Code block font family, line-height and padding in the editor
  • Version 6.6 deleted

Thanks. I needed to open a ticket for the font-family, and that can be fixed in the same patch as the line-height and padding.

#2 @karmatosed
6 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to assign this to myself to test towards to seeing if can commit. Thank you everyone.

#3 @karmatosed
6 months ago

  • Milestone changed from Future Release to 6.7

#4 @karmatosed
5 months ago

  • Keywords commit added

I can confirm in testing this patch resolves the issue for me. I am therefore going to move this to commit, thank you everyone.

#5 @karmatosed
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58852:

Twenty Sixteen: Fixes Code block not showing same line-height and padding on front and in editor.

The Code block had a difference in line-height and padding in the editor and front end. This does not fix font-family which has another ticket.

Props viralsampat, sabernhardt.
Fixes #61700.

Note: See TracTickets for help on using tickets.