Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#61700 closed defect (bug) (fixed)

Twenty Sixteen: correct Code block font family, line-height and padding in the editor

Reported by: viralsampat Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch needs-testing commit
Cc: Focuses: css

Description

Hello Team,

I have reviewed the "code" block and found that its line-height is not same on editor and front-end sides.

I think that is should be same on both(Editor & front-end) sides.

Here, I have provided its screenshots:

Thanks,

Attachments (3)

Screenshot 2024-07-19 at 12.11.18 AM.png​ (415.0 KB ) - added by viralsampat 2 years ago.
Issue back-end screenshot:
Screenshot 2024-07-19 at 12.13.38 AM.png​ (322.9 KB ) - added by viralsampat 2 years ago.
Issue front-end screenshot:
61700.diff​ (505 bytes ) - added by sabernhardt 2 years ago.
adds font-family and line-height values from front-end styles, and corrects the padding

Download all attachments as: .zip

Change History (8)

@viralsampat
2 years ago

Issue back-end screenshot:

@viralsampat
2 years ago

Issue front-end screenshot:

@sabernhardt
2 years ago

adds font-family and line-height values from front-end styles, and corrects the padding

#1 @sabernhardt
2 years ago

  • Component General → Bundled Theme
  • Keywords dev-feedback removed
  • Milestone Awaiting Review → Future Release
  • Summary Twenty Sixteen: The code block line-height is not same on editor & front-end sides. → Twenty Sixteen: correct Code block font family, line-height and padding in the editor
  • Version 6.6

Thanks. I needed to open a ticket for the font-family, and that can be fixed in the same patch as the line-height and padding.

#2 @karmatosed
2 years ago

  • Owner set to karmatosed
  • Status new → assigned

I am going to assign this to myself to test towards to seeing if can commit. Thank you everyone.

#3 @karmatosed
2 years ago

  • Milestone Future Release → 6.7

#4 @karmatosed
2 years ago

  • Keywords commit added

I can confirm in testing this patch resolves the issue for me. I am therefore going to move this to commit, thank you everyone.

#5 @karmatosed
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58852:

Twenty Sixteen: Fixes Code block not showing same line-height and padding on front and in editor.

The Code block had a difference in line-height and padding in the editor and front end. This does not fix font-family which has another ticket.

Props viralsampat, sabernhardt.
Fixes #61700.

Note: See TracTickets for help on using tickets.