Make WordPress Core

Opened 4 months ago

Closed 4 weeks ago

#61709 closed defect (bug) (invalid)

6.6 introduces an in-line display:flow-root on Gutenberg's .is-root-container

Reported by: kristoffbertram's profile kristoffbertram Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.6
Component: General Keywords: needs-testing-info reporter-feedback close
Focuses: css Cc:

Description

I target .is-root-container for creating complex custom layouts (using editor styles.)
It's not the worst to fix, but does require !important. The addition appears unnecessary.

Change History (7)

This ticket was mentioned in Slack in #core-editor by hellofromtonya. View the logs.


4 months ago

#2 @aaronrobertshaw
3 months ago

Thank you for reporting this @kristoffbertram

After a little digging, I found out the following:

  • This display: flow-root style previously existed in the editor styles for the site editor
  • In https://github.com/WordPress/gutenberg/pull/61896 a refactor was completed to move the ability to resize the editor, to the editor package, so it could be consistent between site and post editors
  • This meant the post editor now has the display: flow-root style as well
  • Eventually, the goal is to be able to unify both editors

6.6 introduces an in-line display:flow-root on Gutenberg's .is-root-container

I couldn't replicate any inline display: flow-root style on the .is-root-container element. There is a style added that targets the .is-root-container class though. It appears, you shouldn't need to add ! important to your styles.

If you still see an inline style on the root container, could you provide further details on how this can be replicated?

This ticket was mentioned in Slack in #core-test by ankit-k-gupta. View the logs.


3 months ago

#4 @Hitendra Chopda
3 months ago

  • Keywords needs-testing-info added
  • Resolution set to invalid
  • Status changed from new to closed

#5 @Ankit K Gupta
3 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#6 @hellofromTonya
2 months ago

  • Keywords reporter-feedback close added; changes-requested removed

Following up on this ticket for 6.6.x minor cycle.

@aaronrobertshaw shared more details and asked for steps to reproduce the issue:

I couldn't replicate any inline display: flow-root style on the .is-root-container element. There is a style added that targets the .is-root-container class though. It appears, you shouldn't need to add ! important to your styles.

If you still see an inline style on the root container, could you provide further details on how this can be replicated?

Adding reporter-feedback keyword. @kristoffbertram can you provide step-by-step instructions on how to reproduce the issue?

I'm adding close keyword to denote this ticket needs to be reported upstream in the Gutenberg repository, as that is where it will be investigated and resolved.

@kristoffbertram if the issue persists for you, can you open an issue here and share step-by-step instructions on how to reproduce it? Screenshots and/or recordings also help contributors in their triage. Thanks.

#7 @hellofromTonya
4 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

With no follow-up on how to reproduce or if the issue still persists, am assuming the root cause is a plugin or theme.

If the issue persists and is caused by a plugin or theme, you can find people who are able to assist with your site in the WordPress support forums.

I've closed this ticket as invalid, which is Trac's unfriendly term to indicate I've referred you to the support team.

However, if the issue is or may be due to Core, please open an issue here and share step-by-step instructions on how to reproduce it. Then this ticket's resolution should be changed to reported-upstream.

Note: See TracTickets for help on using tickets.