Text "None" disappeared from Align Display in WordPress 6.6

[Marius84]

None text disappeared from Align Display in WordPress 6.6

​https://mariushosting.com/wp-content/uploads/2024/07/missing-text-none.png

[sabernhardt]

adds echo or uses _ex()

[sabernhardt]

[58284] switched to contextual translation functions but missed adding echo (or using _ex()).

Adding media in Classic Editor or a Classic block

Add media: Attachment Display Settings section

• Alignment (line 843)
• Link To (line 870)

Edit gallery: Gallery Settings section

• Link To (line 955)

Insert from URL

• Align (line 1099)
• Link To (line 1116)

Replacing media in Classic Editor or a Classic block

Image details: Display Settings section

• Align (line 1163)
• Link To (line 1239)

Audio details

• Preload (line 1359)

Video details

• Preload (line 1458)

Possible additional edits

Line 955 has 'Media link target' for its context, and I think it should be the same for the other three "Link To" -> "None" options (lines 870, 1116, and 1239). If so, I could update the patch.

[sabernhardt]

matches context to pre-existing block editor translations (and echoes string)

[sabernhardt]

I made another patch to reuse ​contextual translations from the block editor (GB34341, GB40273).

• 'Alignment option' (created for ​block alignment settings)
• 'Media item link option'
• 'Preload value'

[sabernhardt]

the Link Manager does not show 'none' labels for XFN settings

[sabernhardt]

Oops. The meta-boxes.php file needs updating too. I'll still make two patches because editing the context is not as important or urgent as echoing the strings.

[sabernhardt]

echo strings for link XFN-related labels and media item options/buttons

[sabernhardt]

echo strings for link labels and media items, and reuse context from block editor translations

[sabernhardt]

To test the XFN labels, install and activate the ​Link Manager plugin.

[SergeyBiryukov]

In 58774:

I18N: Correctly output the None translatable strings.

Includes updating the context to match the pre-existing block editor translations.

Follow-up to [58284].

Props sabernhardt, Marius84.
Fixes #61714.

[SergeyBiryukov]

Hi there, thanks for the ticket! Reopening for 6.6.2 consideration.

[hellofromTonya]

Tested before and after [58774] on the 6.6 branch to confirm can reproduce and [58774] resolves the bugs. LGTM for backporting the 6.6 branch.

Reassigning to me for the backport commit.

[hellofromTonya]

In 58805:

I18N: Correctly output the None translatable strings.

Includes updating the context to match the pre-existing block editor translations.

Follow-up to [58284].

Reviewed by hellofromTonya.
Merges [58774] to the 6.6 branch.

Props sabernhardt, Marius84.
Fixes #61714.