Only type cast a scalar $comment_id in get_comment_author_link()

[SergeyBiryukov]

Background: #60475, #61681.

In [58755], get_comment_author() was updated to only cast $comment_id to a string if the value is scalar.

As ​noted by @mukesh27, get_comment_author_link() has a similar code fragment (introduced in [55289]) and should be updated too for consistency.

Trac ticket: https://core.trac.wordpress.org/ticket/61715

[mukesh27]

Thanks, @narenin, for the PR.

Just for your information, the good-first-bug type is intended for new contributors to help them onboard. Since you are already familiar with contributing, please avoid submitting PRs or patches for these types of tickets.

Hope you understand. Thanks!

[narenin]

Thanks for reviewing the PR @mukesh27

I will take care of this.

[iflairwebtechnologies]

Improve type handling and readability in get_comment_author() function

[iflairwebtechnologies]

Reviewed and updated the get_comment_author() function in wp-includes/comment-template.php to improve type handling and readability. This function is critical for retrieving and formatting the comment author's information in WordPress.

[SergeyBiryukov]

Replying to iflairwebtechnologies:

Reviewed and updated the get_comment_author() function in wp-includes/comment-template.php to improve type handling and readability.

Thanks for the patch! I might be missing something, but I don't see any changes to the get_comment_author_link() function in that patch, which was the point of this ticket. Instead, the patch appears to remove all of the contents in the wp-includes/comment-template.php file.

Track ticket: https://core.trac.wordpress.org/ticket/61715

[iflairwebtechnologies]

Fix for comment template issue in wp-includes #61715. Please review new patch file.

Thanks for the PR.

It's duplicate PR of #7066

[SergeyBiryukov]

In 58809:

Comments: Only type cast a scalar $comment_id in get_comment_author_link().

This aims to resolve a fatal error when the incoming $comment_id is an instance of WP_Comment (or any object) without a comment_ID property defined, or if it's empty:

Object of class WP_Comment could not be converted to string

This commit mirrors the changes previously made for a similar code fragment in get_comment_author().

Includes:

• Unit tests to demonstrate the fatal error and validate the fix.
• Changing the default value for a non-existent comment ID in get_comment_author() from an empty string to zero as a numeric string, for consistency with get_comment_ID().

Follow-up to [52818], [55289], [58335], [58755].

Props narenin, mukesh27, iflairwebtechnologies, umeshsinghin, SergeyBiryukov.
Fixes #61715.

Thanks for the PR! Merged in r58809.