#61720 closed enhancement (fixed)
Background: add background attachment support to theme.json styles
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.7 | Priority: | normal |
Severity: | normal | Version: | 6.7 |
Component: | Themes | Keywords: | has-patch has-unit-tests gutenberg-merge |
Focuses: | Cc: |
Description
A ticket to track the syncing of the PHP files for following Gutenberg PR:
It introduces the ability to specify a value for background.backgroundAttachment
in theme.json styles, which sets a CSS value for the background-attachment
property.
Change History (12)
This ticket was mentioned in PR #6991 on WordPress/wordpress-develop by @ramonopoly.
8 months ago
#1
@ramonopoly commented on PR #6991:
8 months ago
#2
I've rebased on top of https://github.com/WordPress/wordpress-develop/pull/6836 and have added theme json block-level tests.
One thing to note is that https://github.com/WordPress/wordpress-develop/pull/6836 opens up block-level global styles, so I've updated the theme.json test snippet in the description.
🍺
@noisysocks commented on PR #6991:
8 months ago
#3
@ramonjd: Is this ready to commit?
@ramonopoly commented on PR #6991:
8 months ago
#4
Is this ready to commit?
Oh yes, please!!
@noisysocks commented on PR #6991:
8 months ago
#5
I intended that as a nudge for you... 😂 You win this round, I was unclear.
@ramonopoly commented on PR #6991:
8 months ago
#6
I intended that as a nudge for you... 😂 You win this round, I was unclear.
Haha. No worries. I mistakenly assumed there was some rule about committing your own patches.
#7
@
8 months ago
- Owner set to ramonopoly
- Resolution set to fixed
- Status changed from new to closed
In 58834:
@ramonopoly commented on PR #6991:
8 months ago
#8
@noisysocks commented on PR #6991:
8 months ago
#9
Thanks!
Syncing changes from https://github.com/WordPress/gutenberg/pull/61382
## Testing
This PR adds the backend functionality only, which means the editor UI isn't yet available.
To test, define a background image for the site in theme.json.
Here's an example using an image in src/wp-content/themes/twentytwentyfour/
Now check the site:
https://github.com/user-attachments/assets/6679d670-b306-45b4-858a-0b490bee5595
Trac ticket: https://core.trac.wordpress.org/ticket/61720