`delete_network_option` sets network `notoptions` cache on non-multisites, but `add_network_option` and `update_network_option` do not clear it

[bjorsch]

On a non-multisite, get_network_option(), add_network_option(), and update_network_option() don't bother updating the network notoptions cache, instead reling on get_option(), add_option(), and update_option() to use the non-network notoptions.

r58782 had delete_network_option() start updating the network notoptions cache even on non-multisites, which breaks the other functions since they do check this otherwise-unused-on-non-multisites cache.

Testing using wp shell:

wp> add_network_option( 1, 'some-option', 'xyz' );
=> bool(true)
wp> delete_network_option( 1, 'some-option' );
=> bool(true)
wp> wp_cache_get( '1:notoptions', 'site-options' );
=> array(1) {
  ["some-option"]=>
  bool(true)
}
wp> add_network_option( 1, 'some-option', 'abc' );
=> bool(true)
wp> wp_cache_get( '1:notoptions', 'site-options' );
=> array(1) {
  ["some-option"]=>
  bool(true)
}
wp> get_network_option( 1, 'some-option' );
=> bool(false)

On a non-multisite, get_network_option(), add_network_option(), and update_network_option() don't bother updating the network notoptions cache, instead reling on get_option(), add_option(), and update_option() to use the non-network notoptions.

delete_options() and delete_network_options() were recently updated to populate the notoptions caches. But, contrary to existing practice, delete_network_options() was made to update the network notoptions cache even on non-multisites.

This moves the updating of the network notoptions cache in delete_network_options() to the multisite code path, matching the behavior of the other functions, and adds a test to verify this.

Trac ticket: https://core.trac.wordpress.org/ticket/61730

An alternative fix would be to update the other functions to all populate the network notoptions cache, but this seemed more straightforward.

[peterwilsoncc]

Thanks for the report @bjorsch, I've moved this on to the 6.7 milestone.

I'll review your pull request an take a look at the differences between how the various network options behave on single site installations.

[pbearne]

This looks like a good change to the 61484 patch

[peterwilsoncc]

In 58811:

Options, Meta APIs: Prevent Single Site installs using network notoptions cache.

Modifies the caching of notoptions in delete_network_option() to ensure that the network cache is bypassed on single site installs.

On single site installs the incorrect caching was causing the notoptions cache to remain populated once a deleted option was subsequently added or updated.

Follow up to [58782].

Props bjorsch, pbearne.
Fixes #61730.
See #61484.

Merged r58811 / ​https://github.com/WordPress/wordpress-develop/commit/b38541de39c5e3ccb75ff76b49ab930846c878b6

Thanks for catching this, Brad, it's much appreciated.