Make WordPress Core

Opened 5 months ago

Last modified 8 days ago

#61765 assigned enhancement

Twenty Twelve: The large quote pattern does not use a quote block

Reported by: poena's profile poena Owned by:
Milestone: 6.8 Priority: low
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch needs-testing
Focuses: Cc:

Description

The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.

I suggest updating the blocks in the pattern and use a quote.

Attachments (10)

61765.diff (3.4 KB) - added by iflairwebtechnologies 5 months ago.
Review quote pattern issue
61765.patch (3.4 KB) - added by iflairwebtechnologies 5 months ago.
Review quote pattern issue here also attached patch file
SCR-20240727-kywa.png (201.4 KB) - added by karmatosed 5 months ago.
61765.2.patch (2.7 KB) - added by iflairwebtechnologies 4 months ago.
Revise updated code
61765.3.patch (3.7 KB) - added by iflairwebtechnologies 4 months ago.
61765.4.patch (1.8 KB) - added by wpeople 4 months ago.
Updated Patch
before patch.jpg (234.2 KB) - added by nithins53 3 months ago.
Before applying the patch
after patch.jpg (249.5 KB) - added by nithins53 3 months ago.
after applying the patch
Before patch.jpg (426.9 KB) - added by balub 3 months ago.
Before patch
After patch.jpg (455.4 KB) - added by balub 3 months ago.
After patch

Download all attachments as: .zip

Change History (32)

#1 @poena
5 months ago

  • Keywords good-first-bug added

@iflairwebtechnologies
5 months ago

Review quote pattern issue

#2 @iflairwebtechnologies
5 months ago

Please review here 61765.diff the solved issue about Twenty Twelve: The large quote pattern does not use a quote block

@iflairwebtechnologies
5 months ago

Review quote pattern issue here also attached patch file

This ticket was mentioned in PR #7099 on WordPress/wordpress-develop by iflair.


5 months ago
#3

  • Keywords has-patch added

Fixes #61765 : Twenty Twelve The large quote pattern fix to use a quote block

#4 @karmatosed
5 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#5 @karmatosed
5 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 6.7

Thank you everyone this makes sense to me. I am going to go ahead and test to see about getting this in.

#6 @karmatosed
5 months ago

Unfortunately in testing this patch ends up with blocks being unable to be recovered due to the changes. I would suggest more testing and looking at this @iflairwebtechnologies in your patch.

#7 @karmatosed
5 months ago

  • Keywords changes-requested added

#8 @karmatosed
4 months ago

  • Owner karmatosed deleted

@iflairwebtechnologies
4 months ago

Revise updated code

#9 @iflairwebtechnologies
4 months ago

@karmatosed
We have tested the code and also made changes in the code

#10 @shailu25
4 months ago

  • Keywords changes-requested removed

#11 @sabernhardt
4 months ago

  • Keywords changes-requested added; needs-testing removed

To replace blocks in a theme's pattern:

  1. Copy the content value from the block pattern PHP (and paste the code into a separate file).
  2. Activate the theme.
  3. Go to the editor and insert that pattern.
  4. Transform the block(s) to another block.
  5. Adjust block settings and/or markup, if appropriate. (With the Quote block in Twenty Twelve, the em tags are unnecessary because both the paragraph and citation are italicized.)
  6. Switch to Code view, and copy the new block(s).
  7. Paste that into the block pattern PHP, in the content value.
  8. Indent any new lines (with tabs).
  9. Replace any text with the translatable strings you copied in step 1.
  10. Return to the editor, and insert the updated pattern.
  11. Switch to Code view, and verify that the pattern matches what you made in steps 4 and 5.
			'content'       => '<!-- wp:quote -->
				<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"fontSize":"40px","lineHeight":1.5}}} -->
				<p style="font-size:40px;line-height:1.5"><strong>' . esc_html__( '"Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions."', 'twentytwelve' ) . '</strong></p>
				<!-- /wp:paragraph --><cite>' . esc_html__( '—  Albert Einstein', 'twentytwelve' ) . '</cite></blockquote>
				<!-- /wp:quote -->',

The nested Paragraph block above could produce invalid/unexpected content errors in older versions of WordPress, though I think that is the best option.

  • Block patterns were introduced in WordPress 5.5.
  • Twenty Twelve added its patterns in #51105, at the same time as WordPress 5.8.
  • The Quote block started nesting a Paragraph block inside it in WordPress 6.1.

The comment also needs updating because the pattern does not have a heading. Suggestion:

// Quote with large paragraph text.
Last edited 2 months ago by sabernhardt (previous) (diff)

#12 @iflairwebtechnologies
4 months ago

@sabernhardt
You can review 61765.3.patch,
Uploaded a new patch here with updated changes

@wpeople
4 months ago

Updated Patch

#13 @wpeople
4 months ago

I have Updated Patch because there was an issue with cite text and also space is missing in inline comment

  • cite Text should be — Albert Einstein instead of ΓÇö Albert Einstein
  • Added Space in Inline Comment.
Last edited 4 months ago by wpeople (previous) (diff)

This ticket was mentioned in Slack in #core by chaion07. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-themes by poena. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by stoyangeorgiev. View the logs.


3 months ago

#17 @sabernhardt
3 months ago

  • Keywords needs-testing added; changes-requested removed

#18 @nithins53
3 months ago

I tested the 61765.4.patch and it works. Attaching images below for reference.

@nithins53
3 months ago

Before applying the patch

@nithins53
3 months ago

after applying the patch

#19 @balub
3 months ago

Patch 61765.4 was tested and the patch was working. Images of the tested patch are attached below.

@balub
3 months ago

Before patch

@balub
3 months ago

After patch

#20 @sabernhardt
2 months ago

61765.4.patch works for me in trunk, and I was also able to add the pattern in WordPress 6.1 and 6.2. I had the unexpected content error in 6.0, but that might not be a blocker.

I would like feedback from @poena before recommending for commit consideration. (With your limited time and higher priorities, this can be pushed to 6.8.)

#21 @davidbaumwald
2 months ago

  • Milestone changed from 6.7 to 6.8

Agree with @sabernhardt. With this being low prio, and most work focused on getting TT5 to the finish line in 6.7, let's move this to 6.8.

@poena If you or any other committer feels the remaining work can be resolved in time for Beta 1 and wishes to assume ownership, feel free to update the milestone accordingly.

#22 @sukhendu2002
8 days ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61765/61765.4.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twelve 4.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.
  2. The "Left-aligned Large Quote" pattern now correctly inserts a quote block, aligning functionality with its name.

Supplemental Artifacts

Before: https://utfs.io/f/TTyF6MLuAyHDmHUe2d7cy0ML1dvzKaDCHngR4TXU9ulNPpbV
After: https://utfs.io/f/TTyF6MLuAyHDx6oAdzlWE8K7S6oCBbeO025dgyihRPMVXYkl

Note: See TracTickets for help on using tickets.