Twenty Twelve: The large quote pattern does not use a quote block

[poena]

The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.

I suggest updating the blocks in the pattern and use a quote.

[iflairwebtechnologies]

Review quote pattern issue

[iflairwebtechnologies]

Please review here 61765.diff the solved issue about Twenty Twelve: The large quote pattern does not use a quote block

[iflairwebtechnologies]

Review quote pattern issue here also attached patch file

Fixes #61765 : Twenty Twelve The large quote pattern fix to use a quote block

[karmatosed]

Thank you everyone this makes sense to me. I am going to go ahead and test to see about getting this in.

[karmatosed]

Unfortunately in testing this patch ends up with blocks being unable to be recovered due to the changes. I would suggest more testing and looking at this @iflairwebtechnologies in your patch.

[iflairwebtechnologies]

Revise updated code

[iflairwebtechnologies]

@karmatosed
We have tested the code and also made changes in the code

[sabernhardt]

To replace blocks in a theme's pattern:

1. Copy the content value from the block pattern PHP (and paste the code into a separate file).
2. Activate the theme.
3. Go to the editor and insert that pattern.
4. Transform the block(s) to another block.
5. Adjust block settings and/or markup, if appropriate. (With the Quote block in Twenty Twelve, the em tags are unnecessary because both the paragraph and citation are italicized.)
6. Switch to Code view, and copy the new block(s).
7. Paste that into the block pattern PHP, in the content value.
8. Indent any new lines (with tabs).
9. Replace any text with the translatable strings you copied in step 1.
10. Return to the editor, and insert the updated pattern.
11. Switch to Code view, and verify that the pattern matches what you made in steps 4 and 5.

			'content'       => '<!-- wp:quote -->
				<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"fontSize":"40px","lineHeight":1.5}}} -->
				<p style="font-size:40px;line-height:1.5"><strong>' . esc_html__( '"Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions."', 'twentytwelve' ) . '</strong></p>
				<!-- /wp:paragraph --><cite>' . esc_html__( '—  Albert Einstein', 'twentytwelve' ) . '</cite></blockquote>
				<!-- /wp:quote -->',

The nested Paragraph block above could produce invalid/unexpected content errors in older versions of WordPress, though I think that is the best option.

• Block patterns were introduced in WordPress 5.5.
• Twenty Twelve added its patterns in #51105, at the same time as WordPress 5.8.
• The Quote block started nesting a Paragraph block inside it in WordPress 6.1.

The comment also needs updating because the pattern does not have a heading. Suggestion:

// Quote with large paragraph text.

[iflairwebtechnologies]

@sabernhardt
You can review 61765.3.patch,
Uploaded a new patch here with updated changes

[wpeople]

Updated Patch

[wpeople]

I have Updated Patch because there was an issue with cite text and also space is missing in inline comment

• cite Text should be — Albert Einstein instead of ΓÇö Albert Einstein
• Added Space in Inline Comment.

[nithins53]

I tested the 61765.4.patch and it works. Attaching images below for reference.

[nithins53]

Before applying the patch

[nithins53]

after applying the patch

[balub]

Patch 61765.4 was tested and the patch was working. Images of the tested patch are attached below.

[balub]

Before patch

[balub]

After patch

[sabernhardt]

61765.4.patch works for me in trunk, and I was also able to add the pattern in WordPress 6.1 and 6.2. I had the unexpected content error in 6.0, but that might not be a blocker.

I would like feedback from @poena before recommending for commit consideration. (With your limited time and higher priorities, this can be pushed to 6.8.)

[davidbaumwald]

Agree with @sabernhardt. With this being low prio, and most work focused on getting TT5 to the finish line in 6.7, let's move this to 6.8.

@poena If you or any other committer feels the remaining work can be resolved in time for Beta 1 and wishes to assume ownership, feel free to update the milestone accordingly.

[sukhendu2002]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/61765/61765.4.patch

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.26
• Server: nginx/1.27.3
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twelve 4.4
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.
2. The "Left-aligned Large Quote" pattern now correctly inserts a quote block, aligning functionality with its name.

Supplemental Artifacts

Before:
After:

[poena]

Hi

I have a question before committing this change:
Patch 3 shows that there may be encoding issues with the em dash character in the pattern text. Patch 4 is correct, but should the em dash be replaced by the HTML entity — instead?

[dilip2615]

Hello @poena according to my thoughts,In the Twenty Twelve theme, the large quote pattern might be using a custom HTML structure or CSS styling instead of utilizing the native WordPress quote block (<blockquote>). This can affect the semantic structure and block editor consistency.

<?php
register_block_pattern(
    'twentytwelve/large-quote',
    array(
        'title'       => __( 'Large Quote', 'twentytwelve' ),
        'description' => __( 'A large quote using the quote block.', 'twentytwelve' ),
        'content'     => '<!-- wp:quote {"className":"large-quote"} -->
        <blockquote class="wp-block-quote large-quote">
            <p>' . esc_html__( 'This is a large quote example.', 'twentytwelve' ) . '</p>
            <cite>' . esc_html__( 'Author Name', 'twentytwelve' ) . '</cite>
        </blockquote>
        <!-- /wp:quote -->',
        'categories'  => array( 'text' ),
    )
);

after need to update bellow css

.large-quote {

font-size: 2em;
font-style: italic;
text-align: center;
border-left: 5px solid #ccc;
padding-left: 20px;

}

[poena]

@dilip2615 perhaps there is a language issue but I did not understand what you are responding to.

There is already a working patch.
The patch has the styling including font size applied to the block.

What I was asking in comment 23 was if the em dash should be replaced by the HTML entity.

[poena]

I did not look through the CSS today (replying from my phone :) ). But I believe the intention is to keep any CSS the same so that the patterns that are already placed do not break or change design.

These patterns are not synced, patterns that are already placed do not have a connection to the new pattern code and will not be updated when the new code is added to the theme.

[dilip2615]

Replying to poena:Yes I know @poena,Thanks for the suggestion regarding modifying the pattern. However, the styling and block implementation are already addressed in the existing patch. My concern is whether the em dash (—) used in the quote should be replaced with the HTML entity (&mdash;). Could you confirm if it's necessary for consistency and best practices, or if the current usage is acceptable?

@dilip2615 perhaps there is a language issue but I did not understand what you are responding to.

There is already a working patch.
The patch has the styling including font size applied to the block.

What I was asking in comment 23 was if the em dash should be replaced by the HTML entity.

[itpathsolutions]

Updated Patch

[itpathsolutions]

Updated Patch as Per suggested in this comment

[poena]

There are still language difficulties, I don't want to be rude but I am struggling to understand you.

I am asking the question, so I don't know why you are asking me to confirm and answer my own question...

[shraddhagore]

Patch report: https://core.trac.wordpress.org/attachment/ticket/61765/61765.5.patch

Environment:
WordPress: 6.8-alpha-59274-src
Theme: Twenty Twelve
Browser: Google Chrome
OS: Windows 11

Screenshots:
Before: ​https://prnt.sc/sxVzFnzKetdQ
After: ​https://prnt.sc/cwALkU0ENgRX

Comments:
The patch 5 is working as expected.

[shailu25]

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/61765/61765.5.patch

Environment:

WordPress - 6.7.2
OS - Windows
Browser - Firefox
Theme: Twenty Twelve
PHP - 8.2.12

Actual Results:

• Issue Resolved With Patch✅

[shailu25]

Before Patch Backend

[shailu25]

After Patch Backend

[shailu25]

After Patch Frontend

[ugyensupport]

Twenty Twelve: The large quote pattern does not use a quote block

Description

The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.

I suggest updating the blocks in the pattern and use a quote.

Patch tested:
https://core.trac.wordpress.org/attachment/ticket/61765/61765.5.patch

Environment

• WordPress: 6.7.3-alpha-59811
• PHP: 8.4.1
• Server: Apache/2.4.62 (Unix) mod_wsgi/5.0.1 Python/3.12 mod_fastcgi/mod_fastcgi-SNAP-0910052141 OpenSSL/1.1.1w
• Database: mysqli (Server: 5.7.44 / Client: mysqlnd 8.4.1)
• Browser: Chrome 133.0.0.0
• OS: macOS
• Theme: Twenty Twelve 4.4
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before: ​https://ibb.co/k2T6hFZj
After: ​https://ibb.co/nN7s1L7W

[poena]

I acknowledge that this change will create a block validation error on some older WordPress versions when the pattern is inserted. The validation error can be resolved in the editor and I believe the impact is small.

[poena]

In 59842:

Twenty Twelve: Update the quote pattern to use the quote block.

This change updates the Left-aligned Large Quote pattern to use the quote block instead of
paragraph blocks.

Props flairwebtechnologies, sabernhardt, karmatosed, wpeople, poena, nithins53, balub, sukhendu2002, dilip2615, itpathsolutions, shraddhagore, shailu25.
Fixes #61765.