Opened 5 months ago
Last modified 8 days ago
#61765 assigned enhancement
Twenty Twelve: The large quote pattern does not use a quote block
Reported by: | poena | Owned by: | |
---|---|---|---|
Milestone: | 6.8 | Priority: | low |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch needs-testing |
Focuses: | Cc: |
Description
The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.
I suggest updating the blocks in the pattern and use a quote.
Attachments (10)
Change History (32)
#2
@
5 months ago
Please review here 61765.diff the solved issue about Twenty Twelve: The large quote pattern does not use a quote block
This ticket was mentioned in PR #7099 on WordPress/wordpress-develop by iflair.
5 months ago
#3
- Keywords has-patch added
Fixes #61765 : Twenty Twelve The large quote pattern fix to use a quote block
#5
@
5 months ago
- Keywords needs-testing added
- Milestone changed from Awaiting Review to 6.7
Thank you everyone this makes sense to me. I am going to go ahead and test to see about getting this in.
#6
@
5 months ago
Unfortunately in testing this patch ends up with blocks being unable to be recovered due to the changes. I would suggest more testing and looking at this @iflairwebtechnologies in your patch.
#11
@
4 months ago
- Keywords changes-requested added; needs-testing removed
To replace blocks in a theme's pattern:
- Copy the
content
value from the block pattern PHP (and paste the code into a separate file). - Activate the theme.
- Go to the editor and insert that pattern.
- Transform the block(s) to another block.
- Adjust block settings and/or markup, if appropriate. (With the Quote block in Twenty Twelve, the
em
tags are unnecessary because both the paragraph and citation are italicized.) - Switch to Code view, and copy the new block(s).
- Paste that into the block pattern PHP, in the
content
value. - Indent any new lines (with tabs).
- Replace any text with the translatable strings you copied in step 1.
- Return to the editor, and insert the updated pattern.
- Switch to Code view, and verify that the pattern matches what you made in steps 4 and 5.
'content' => '<!-- wp:quote --> <blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"fontSize":"40px","lineHeight":1.5}}} --> <p style="font-size:40px;line-height:1.5"><strong>' . esc_html__( '"Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions."', 'twentytwelve' ) . '</strong></p> <!-- /wp:paragraph --><cite>' . esc_html__( '— Albert Einstein', 'twentytwelve' ) . '</cite></blockquote> <!-- /wp:quote -->',
The nested Paragraph block above could produce invalid/unexpected content errors in older versions of WordPress, though I think that is the best option.
- Block patterns were introduced in WordPress 5.5.
- Twenty Twelve added its patterns in #51105, at the same time as WordPress 5.8.
- The Quote block started nesting a Paragraph block inside it in WordPress 6.1.
The comment also needs updating because the pattern does not have a heading. Suggestion:
// Quote with large paragraph text.
#12
@
4 months ago
@sabernhardt
You can review 61765.3.patch,
Uploaded a new patch here with updated changes
#13
@
4 months ago
I have Updated Patch because there was an issue with cite text and also space is missing in inline comment
- cite Text should be
— Albert Einstein
instead ofΓÇö Albert Einstein
- Added Space in Inline Comment.
This ticket was mentioned in Slack in #core by chaion07. View the logs.
3 months ago
This ticket was mentioned in Slack in #core-themes by poena. View the logs.
3 months ago
This ticket was mentioned in Slack in #core by stoyangeorgiev. View the logs.
3 months ago
#19
@
3 months ago
Patch 61765.4 was tested and the patch was working. Images of the tested patch are attached below.
#20
@
2 months ago
61765.4.patch works for me in trunk, and I was also able to add the pattern in WordPress 6.1 and 6.2. I had the unexpected content error in 6.0, but that might not be a blocker.
I would like feedback from @poena before recommending for commit consideration. (With your limited time and higher priorities, this can be pushed to 6.8.)
#21
@
2 months ago
- Milestone changed from 6.7 to 6.8
Agree with @sabernhardt. With this being low
prio, and most work focused on getting TT5 to the finish line in 6.7, let's move this to 6.8
.
@poena If you or any other committer feels the remaining work can be resolved in time for Beta 1 and wishes to assume ownership, feel free to update the milestone accordingly.
#22
@
8 days ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/61765/61765.4.patch
Environment
- WordPress: 6.8-alpha-59274-src
- PHP: 8.2.26
- Server: nginx/1.27.3
- Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
- Browser: Chrome 131.0.0.0
- OS: macOS
- Theme: Twenty Twelve 4.4
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ Issue resolved with patch.
- The "Left-aligned Large Quote" pattern now correctly inserts a quote block, aligning functionality with its name.
Review quote pattern issue