Twenty Twelve: The large quote pattern does not use a quote block

[poena]

The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.

I suggest updating the blocks in the pattern and use a quote.

[iflairwebtechnologies]

Review quote pattern issue

[iflairwebtechnologies]

Please review here 61765.diff the solved issue about Twenty Twelve: The large quote pattern does not use a quote block

[iflairwebtechnologies]

Review quote pattern issue here also attached patch file

Fixes #61765 : Twenty Twelve The large quote pattern fix to use a quote block

[karmatosed]

Thank you everyone this makes sense to me. I am going to go ahead and test to see about getting this in.

[karmatosed]

Unfortunately in testing this patch ends up with blocks being unable to be recovered due to the changes. I would suggest more testing and looking at this @iflairwebtechnologies in your patch.

[iflairwebtechnologies]

Revise updated code

[iflairwebtechnologies]

@karmatosed
We have tested the code and also made changes in the code

[sabernhardt]

To replace blocks in a theme's pattern:

1. Copy the content value from the block pattern PHP (and paste the code into a separate file).
2. Activate the theme.
3. Go to the editor and insert that pattern.
4. Transform the block(s) to another block.
5. Adjust block settings and/or markup, if appropriate. (With the Quote block in Twenty Twelve, the em tags are unnecessary because both the paragraph and citation are italicized.)
6. Switch to Code view, and copy the new block(s).
7. Paste that into the block pattern PHP, in the content value.
8. Indent any new lines (with tabs).
9. Replace any text with the translatable strings you copied in step 1.
10. Return to the editor, and insert the updated pattern.
11. Switch to Code view, and verify that the pattern matches what you made in steps 4 and 5.

			'content'       => '<!-- wp:quote -->
				<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"fontSize":"40px","lineHeight":1.5}}} -->
				<p style="font-size:40px;line-height:1.5"><strong>' . esc_html__( '"Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions."', 'twentytwelve' ) . '</strong></p>
				<!-- /wp:paragraph --><cite>' . esc_html__( '—  Albert Einstein', 'twentytwelve' ) . '</cite></blockquote>
				<!-- /wp:quote -->',

The nested Paragraph block above could produce invalid/unexpected content errors in older versions of WordPress, though I think that is the best option.

• Block patterns were introduced in WordPress 5.5.
• Twenty Twelve added its patterns in #51105, at the same time as WordPress 5.8.
• The Quote block started nesting a Paragraph block inside it in WordPress 6.1.

The comment also needs updating because the pattern does not have a heading. Suggestion:

// Quote with large paragraph text.

[iflairwebtechnologies]

@sabernhardt
You can review 61765.3.patch,
Uploaded a new patch here with updated changes

[wpeople]

Updated Patch

[wpeople]

I have Updated Patch because there was an issue with cta text & also space is missing in inline comment

• cite Text should be — Albert Einstein instead of ΓÇö Albert Einstein
• Added Space in Inline Comment ( Quote with large paragraph text.)

[nithins53]

I tested the 61765.4.patch and it works. Attaching images below for reference.

[nithins53]

Before applying the patch

[nithins53]

after applying the patch

[balub]

Patch 61765.4 was tested and the patch was working. Images of the tested patch are attached below.

[balub]

Before patch

[balub]

After patch

[sabernhardt]

61765.4.patch works for me in trunk, and I was also able to add the pattern in WordPress 6.1 and 6.2. I had the unexpected content error in 6.0, but that might not be a blocker.

I would like feedback from @poena before recommending for commit consideration. (With your limited time and higher priorities, this can be pushed to 6.8.)

[davidbaumwald]

Agree with @sabernhardt. With this being low prio, and most work focused on getting TT5 to the finish line in 6.7, let's move this to 6.8.

@poena If you or any other committer feels the remaining work can be resolved in time for Beta 1 and wishes to assume ownership, feel free to update the milestone accordingly.