Opened 6 weeks ago
Last modified 6 days ago
#61765 assigned enhancement
Twenty Twelve: The large quote pattern does not use a quote block
Reported by: | poena | Owned by: | |
---|---|---|---|
Milestone: | 6.7 | Priority: | low |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch changes-requested |
Focuses: | Cc: |
Description
The pattern "Left-aligned Large Quote" does not insert a quote block. Instead, it inserts paragraphs, which is unexpected based on its name.
I suggest updating the blocks in the pattern and use a quote.
Attachments (6)
Change History (21)
#2
@
6 weeks ago
Please review here 61765.diff the solved issue about Twenty Twelve: The large quote pattern does not use a quote block
This ticket was mentioned in PR #7099 on WordPress/wordpress-develop by iflair.
6 weeks ago
#3
- Keywords has-patch added
Fixes #61765 : Twenty Twelve The large quote pattern fix to use a quote block
#5
@
6 weeks ago
- Keywords needs-testing added
- Milestone changed from Awaiting Review to 6.7
Thank you everyone this makes sense to me. I am going to go ahead and test to see about getting this in.
#6
@
6 weeks ago
Unfortunately in testing this patch ends up with blocks being unable to be recovered due to the changes. I would suggest more testing and looking at this @iflairwebtechnologies in your patch.
#11
@
6 weeks ago
- Keywords changes-requested added; needs-testing removed
To replace blocks in a theme's pattern:
- Copy the
content
value from the block pattern PHP. - Activate the theme.
- Go to the editor and insert that pattern.
- Transform the block(s) to another block.
- Adjust block settings and/or markup, if appropriate. (With the Quote block in Twenty Twelve, the
em
tags are unnecessary because both the paragraph and citation are italicized.) - Switch to Code view, and copy the new block(s).
- Paste that into the block pattern PHP, in the
content
value. - Indent any new lines (with tabs).
- Replace any text with the translatable strings you copied in step 1.
- Return to the editor, and insert the updated pattern.
- Switch to Code view, and verify that the pattern matches what you made in steps 4 and 5.
'content' => '<!-- wp:quote --> <blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"fontSize":"40px","lineHeight":1.5}}} --> <p style="font-size:40px;line-height:1.5"><strong>' . esc_html__( '"Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions."', 'twentytwelve' ) . '</strong></p> <!-- /wp:paragraph --><cite>' . esc_html__( '— Albert Einstein', 'twentytwelve' ) . '</cite></blockquote> <!-- /wp:quote -->',
The nested Paragraph block above could produce invalid/unexpected content errors in older versions of WordPress, though I think that is the best option.
- Block patterns were introduced in WordPress 5.5.
- Twenty Twelve added its patterns in #51105, at the same time as WordPress 5.8.
- The Quote block started nesting a Paragraph block inside it in WordPress 6.1.
The comment also needs updating because the pattern does not have a heading. Suggestion:
// Quote with large paragraph text.
#12
@
5 weeks ago
@sabernhardt
You can review 61765.3.patch,
Uploaded a new patch here with updated changes
#13
@
5 weeks ago
I have Updated Patch because there was an issue with cta text & also space is missing in inline comment
- cite Text should be
— Albert Einstein
instead ofΓÇö Albert Einstein
- Added Space in Inline Comment.
Review quote pattern issue