Make WordPress Core

Opened 10 months ago

Last modified 3 months ago

#61766 new enhancement

Multiple bundled themes: Add site logo theme support

Reported by: poena's profile poena Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-testing changes-requested has-patch
Focuses: Cc:

Description

The following themes are missing theme support for site logo. I suggest adding it.
Even if users are able to use the site logo block, they can not easily add the site logo outside the post content or widget areas.

Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Thirteen, Twenty Fourteen.

Change History (17)

This ticket was mentioned in PR #7096 on WordPress/wordpress-develop by @narenin.


10 months ago
#1

  • Keywords has-patch added

narendraie commented on PR #7096:


10 months ago
#2

@mukeshpanchal27 These theme currently not using logo, so please let me know where I need to add that logo to test the frontend.

#3 @karmatosed
10 months ago

  • Keywords needs-testing added

I think this is a good addition but we need to make sure this gets testing now we have a patch. Thanks everyone, let's add the keywords to get that.

#4 @poena
6 months ago

  • Keywords changes-requested added

Twenty Ten - inside <div id="branding" role="banner">, to the left of the site title

Twenty Eleven - inside <header id="branding">> to the left of the site title.

Twenty Twelve - inside <header id="masthead" class="site-header"> to the left of the site title.

Twenty Thirteen - inside <header id="masthead" class="site-header"> to the left of the site title.

Twenty Fourteen - Inside header-main, left of the site title, but the same size as the search icon, since this header is sticky.

Things to consider:
Look for ways to limit the number of links, like placing the logo and title inside the same link.
The themes support older versions of WordPress, the logo needs to be conditional, placed inside a
if ( function_exists...
There should be some reasonable spacing between the logo and title.

#5 @karmatosed
5 months ago

  • Keywords needs-patch added; has-patch removed

This ticket was mentioned in PR #8236 on WordPress/wordpress-develop by @bschneidewind.


4 months ago
#6

  • Keywords has-patch added; needs-patch removed

This picks up where @narenin was at and addresses the twenty-ten, twenty-eleven and twenty-twelve themes.

Twenty-Thirteen and Twenty-Fourteen need to be discussed further before moving forward with any development:
1 - Twenty-Thirteen currently has the anchor tag wrapping the linked text and the site description. This should be updated so that the anchor tag lives inside the h1 and the h2/description is not linked at all.
2 - Twenty-Fourteen may not be suitable for a logo due to the size limitations of the logo area on this theme.

Trac ticket: https://core.trac.wordpress.org/ticket/61766

#7 @bschneidewind
3 months ago

@karmatosed / @poena - I added a patch here that will swap the text logo for an image logo (if set) on the twenty-ten, twenty-eleven and twenty-twelve themes. IMO twenty-thirteen and twenty-fourteen will need further discussion on how to best implement due to space limitations in the header.

On these themes - Do we want/need to display text and an image (if set) or are we good with taking an approach that shows one or the other? (twenty-twenty takes this approach now for reference)

#8 @poena
3 months ago

  • Focuses accessibility added

I don't believe the intention was for the logo to replace the site title.

To me that feels like it would need a Customizer option where the user would decide if it should replace the site title or not, and it is not a common practice to introduce new custom functionality.

I don't think this should be enforced, I would prefer the smallest change possible.
But this is only my opinion.

I don't have the bandwidth to prioritize this right now. I will not be able to reply immediately.

#9 @poena
3 months ago

  • Focuses accessibility removed

#10 @bschneidewind
3 months ago

TwentyTwenty is setup so that when a logo is set, it replaces the site title and does not provide an option for a user to change that.

TwentyTwentyOne also functions the same way, however it does allow the user to display the site title IF they add a tagline and check the box to display both but even then it displays in the menu row and doesn't hide the site logo.

TwentyNineteen display both and does not provide any options for a user to adjust.

TwentyFifteen, TwentySixteen and TwentySeventeen give the option to display both or just the logo.

So... short story long, there really isn't any consistency we can go off of in the bundled themes that already have site logo support.

I think most users that set a logo aren't going to want to display the site title in addition to the logo - but that's just my .02. It seems the best solution would be to give the user the flexibility to choose rather than force them into one method or another.

I can update the PR's to add that option - we are already adding the site logo here and it changes the customizer experience on these themes, it makes sense to add the option we already see in TwentyFifteen, TwentySixteen and TwentySeventeen that allow the user to choose.

This ticket was mentioned in PR #8309 on WordPress/wordpress-develop by @bschneidewind.


3 months ago
#11

On the TwentyTen theme, this adds site logo and header-text support to provide users with the following options:

  1. Displays the site title and site description. (current standard)
  2. Display only the logo (if the user adds a logo)
  3. Display the logo, the site title and the description (if the user adds a logo and the header-text checkbox is ticked)

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8317 on WordPress/wordpress-develop by @bschneidewind.


3 months ago
#12

On the TwentyEleven theme, this adds site logo support to provide users with the following options:

  • Displays the site title and site description. (current standard)
  • Display only the logo (if the user adds a logo and the header-text checkbox is ticked)
  • Display the logo, the site title and the description (if the user adds a logo)

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8323 on WordPress/wordpress-develop by @bschneidewind.


3 months ago
#13

On the TwentyTwelve theme, this adds site logo support to provide users with the following options:

  • Displays the site title and site description. (current standard)
  • Display only the logo (if the user adds a logo)
  • Display the logo, the site title and the description (if the user adds a logo and the header-text checkbox is ticked)

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8324 on WordPress/wordpress-develop by @bschneidewind.


3 months ago
#14

On the TwentyThirteen theme, this adds site logo support to provide users with the following options:

  • Displays the site title and site description. (current standard)
  • Display only the logo (if the user adds a logo)
  • Display the logo, the site title and the description (if the user adds a logo and the header-text checkbox is ticked)

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8325 on WordPress/wordpress-develop by @bschneidewind.


3 months ago
#15

On the TwentyFourteen theme, this adds site logo support to provide users with the following options:

  • Displays the site title and site description. (current standard)
  • Display only the logo (if the user adds a logo)
  • Display the logo, the site title and the description (if the user adds a logo and the header-text checkbox is ticked)

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8366 on WordPress/wordpress-develop by anandraj346.


3 months ago
#16

Referencing PR: #8325
Improved formatting of newly-added code

Trac ticket: https://core.trac.wordpress.org/ticket/61766

This ticket was mentioned in PR #8367 on WordPress/wordpress-develop by anandraj346.


3 months ago
#17

Referencing PR: #8324
Improved formatting of newly-added css code

Trac ticket: https://core.trac.wordpress.org/ticket/61766

Note: See TracTickets for help on using tickets.