Opened 6 months ago
Last modified 3 weeks ago
#61766 new enhancement
Multiple bundled themes: Add site logo theme support
Reported by: | poena | Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | needs-testing changes-requested needs-patch |
Focuses: | Cc: |
Description
The following themes are missing theme support for site logo. I suggest adding it.
Even if users are able to use the site logo block, they can not easily add the site logo outside the post content or widget areas.
Twenty Ten, Twenty Eleven, Twenty Twelve, Twenty Thirteen, Twenty Fourteen.
Change History (5)
This ticket was mentioned in PR #7096 on WordPress/wordpress-develop by @narenin.
6 months ago
#1
- Keywords has-patch added
narendraie commented on PR #7096:
6 months ago
#2
@mukeshpanchal27 These theme currently not using logo, so please let me know where I need to add that logo to test the frontend.
#3
@
6 months ago
- Keywords needs-testing added
I think this is a good addition but we need to make sure this gets testing now we have a patch. Thanks everyone, let's add the keywords to get that.
#4
@
6 weeks ago
- Keywords changes-requested added
Twenty Ten - inside <div id="branding" role="banner">
, to the left of the site title
Twenty Eleven - inside <header id="branding">>
to the left of the site title.
Twenty Twelve - inside <header id="masthead" class="site-header">
to the left of the site title.
Twenty Thirteen - inside <header id="masthead" class="site-header">
to the left of the site title.
Twenty Fourteen - Inside header-main, left of the site title, but the same size as the search icon, since this header is sticky.
Things to consider:
Look for ways to limit the number of links, like placing the logo and title inside the same link.
The themes support older versions of WordPress, the logo needs to be conditional, placed inside a
if ( function_exists...
There should be some reasonable spacing between the logo and title.
Trac ticket: https://core.trac.wordpress.org/ticket/61766