Make WordPress Core

Opened 8 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#61767 closed defect (bug) (wontfix)

Twenty Twelve: hyphens only on front end for pages and widgets

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-testing-info close 2nd-opinion
Focuses: css Cc:

Description

In theme Twenty Twelve, when we add letter spacing the word breaks in frontend only half letter are in one line and half in another line with "-". This might be correct but it should be implemented in both the side or for others themes also.

When I check other theme the word will come in one line only after applying letter spacing also

Here is the recording for the reference :
https://www.loom.com/share/9a6081ceefb042e29161050b761587c6?sid=fda500f1-1d5f-4b2e-9d7a-3552ff7b762b

Attachments (4)

61767.patch (442 bytes) - added by viralsampat 7 weeks ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
twenty-twelve-paragraph-block-editor.png (270.8 KB) - added by viralsampat 7 weeks ago.
Back-end:
twenty-twelve-paragraph-block-front-end.png (234.0 KB) - added by viralsampat 7 weeks ago.
Front-end:
61767.2.patch (489 bytes) - added by viralsampat 7 weeks ago.
I have updated my patch.

Download all attachments as: .zip

Change History (10)

#1 @narenin
8 weeks ago

Hi @pitamdey,

I am also able to replicate the issue.

Environment Details :


WordPress: 6.7-alpha-58576-src
PHP: 8.3.7
Server: nginx/1.25.4
Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
Browser: Chrome 125.0.0.0
OS: macOS
Theme: Twenty TwelveVersion: 4.3
MU Plugins: None activated


#2 @narenin
8 weeks ago

  • Keywords has-testing-info added

#3 @sabernhardt
8 weeks ago

  • Focuses css added
  • Severity changed from normal to minor
  • Summary changed from Twenty Twelve : Letter Spacing break the word and add line in Frontend only to Twenty Twelve: hyphens only on front end for pages and widgets

This is not exactly related to the Letter Spacing control, though it easier to notice with more space between each character.

The front end stylesheet adds hyphens: auto for widgets and post/page content including comments (.widget-area .widget and .site-content article). The editor styles do not set the hyphens property to match the front. Note that hyphens still will not work within the iframe editor until that has a lang attribute (GB52777/GB54150).

Last edited 7 weeks ago by sabernhardt (previous) (diff)

#4 @karmatosed
7 weeks ago

  • Keywords needs-patch added

@viralsampat
7 weeks ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
7 weeks ago

I have updated my patch.

#5 @sabernhardt
7 weeks ago

  • Keywords close 2nd-opinion added; needs-patch removed

The patches would cancel the theme's hyphens

  • on the front end
  • only for paragraphs
  • in the post content, summary and comments (but not widgets) and on the network registration page

Hyphenation is probably most valuable with paragraphs in the post content area. If removing that style could be acceptable, I would propose just deleting the six lines that set the property to auto (and then closing #61800 as unnecessary). However, the hyphens have been part of the theme's design for 12 years.

I'm inclined to leave this unchanged. In the editor, reading whole words as you type them is more important than seeing them split as they would appear on the front. Plus, the paragraph can be a different width in the editor due to a sidebar (either the editor's sidebar controls or the front end's sidebar widgets), so you likely would not find the same words breaking to the next line.

Version 1, edited 7 weeks ago by sabernhardt (previous) (next) (diff)

#6 @karmatosed
6 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thank you for your insights @sabernhardt. On reflection I also agree for a few reasons:

  • As you note this is more important in the editor than on the front.
  • This theme has been released for a while like this.

Therefore, I am going to support this close with a 'won't fix'.

Note: See TracTickets for help on using tickets.