Make WordPress Core

Opened 11 months ago

Last modified 7 weeks ago

#61826 new defect (bug)

Inline Padding Issue with Full-Width (alignfull) child Group in WordPress 6.6

Reported by: tremidkhar's profile tremidkhar Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.6
Component: General Keywords: has-patch has-unit-tests has-screenshots needs-testing
Focuses: Cc:

Description

The inline padding for full-width (alignfull) groups is not being applied as expected. This behavior differs from previous versions, specifically WordPress 6.5.5, where the padding was correctly applied.

Steps to Reproduce:

Create or edit the header.html template.
Add a full-width (alignfull) group with inline padding.
Save the changes and view the header on the frontend.

Expected Behavior:

In WordPress 6.5.5, the header displays with the root inline-padding for spacing.

Observed Behavior:

In WordPress 6.6, the inline padding is not applied, and the header appears without any spacing.

Environment:

WordPress Version: 6.6
Theme: Twenty Twenty Four (with changes only to the header.html template)

Below is a sample code snippet for the header.html template used for testing:

<!-- wp:group {"align":"wide","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group alignwide" style="padding-top:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30)"><!-- wp:group {"align":"full","layout":{"type":"default"}} -->
<div class="wp-block-group alignfull"><!-- wp:group {"layout":{"type":"flex","flexWrap":"wrap","justifyContent":"space-between"}} -->
<div class="wp-block-group"><!-- wp:group {"style":{"spacing":{"blockGap":"var:preset|spacing|20"},"layout":{"selfStretch":"fit","flexSize":null}},"layout":{"type":"flex"}} -->
<div class="wp-block-group"><!-- wp:site-logo {"width":60,"shouldSyncIcon":true} /-->

<!-- wp:group {"style":{"spacing":{"blockGap":"0px"}}} -->
<div class="wp-block-group"><!-- wp:site-title {"level":0} /--></div>
<!-- /wp:group --></div>
<!-- /wp:group -->

<!-- wp:group {"layout":{"type":"flex","flexWrap":"wrap","justifyContent":"left"}} -->
<div class="wp-block-group"><!-- wp:navigation {"ref":5,"style":{"spacing":{"margin":{"top":"0"},"blockGap":"var:preset|spacing|20"},"layout":{"selfStretch":"fit","flexSize":null}},"layout":{"type":"flex","justifyContent":"right","orientation":"horizontal"}} /--></div>
<!-- /wp:group --></div>
<!-- /wp:group --></div>
<!-- /wp:group --></div>
<!-- /wp:group -->

Attachments (4)

WP 6.5.5.png (2.0 MB) - added by tremidkhar 11 months ago.
WP 6.6.png (2.0 MB) - added by tremidkhar 11 months ago.
61826_Before_Patch.jpg (132.1 KB) - added by avinashbhosale 7 weeks ago.
Alignment before patch
61826_After_Patch.jpg (141.1 KB) - added by avinashbhosale 7 weeks ago.
Alignment after patch

Change History (10)

@tremidkhar
11 months ago

@tremidkhar
11 months ago

#1 @tremidkhar
11 months ago

  • Version set to 6.6

#2 @tremidkhar
11 months ago

Here is an updated header.html template code.

<!-- wp:group {"style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group" style="padding-top:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30)"><!-- wp:group {"align":"full","layout":{"type":"default"}} -->
<div class="wp-block-group alignfull"><!-- wp:group {"layout":{"type":"flex","flexWrap":"wrap","justifyContent":"space-between"}} -->
<div class="wp-block-group"><!-- wp:group {"style":{"spacing":{"blockGap":"var:preset|spacing|20"},"layout":{"selfStretch":"fit","flexSize":null}},"layout":{"type":"flex"}} -->
<div class="wp-block-group"><!-- wp:site-logo {"width":60,"shouldSyncIcon":true} /-->

<!-- wp:group {"style":{"spacing":{"blockGap":"0px"}}} -->
<div class="wp-block-group"><!-- wp:site-title {"level":0} /--></div>
<!-- /wp:group --></div>
<!-- /wp:group -->

<!-- wp:group {"layout":{"type":"flex","flexWrap":"wrap","justifyContent":"left"}} -->
<div class="wp-block-group"><!-- wp:navigation {"ref":5,"style":{"spacing":{"margin":{"top":"0"},"blockGap":"var:preset|spacing|20"},"layout":{"selfStretch":"fit","flexSize":null}},"layout":{"type":"flex","justifyContent":"right","orientation":"horizontal"}} /--></div>
<!-- /wp:group --></div>
<!-- /wp:group --></div>
<!-- /wp:group --></div>
<!-- /wp:group -->

#3 @tremidkhar
11 months ago

  • Summary changed from Inline Padding Issue with Full-Width (alignfull) Group in WordPress 6.6 to Inline Padding Issue with Full-Width (alignfull) child Group in WordPress 6.6

This ticket was mentioned in PR #7140 on WordPress/wordpress-develop by @tremidkhar.


11 months ago
#4

  • Keywords has-patch has-unit-tests added

#5 @tremidkhar
11 months ago

  • Keywords has-screenshots needs-testing added

#6 @avinashbhosale
7 weeks ago

Test Report

Description

This report validates that the patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7140

Environment

  • WordPress: 6.8.1
  • PHP: 8.2.27
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.27)
  • Browser: Chrome 137.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Four 1.3
  • MU Plugins: None activated
  • Plugins:
    • Admin and Site Enhancements (ASE) 7.8.12
    • Site Kit by Google 1.153.0
    • Test Reports 1.2.0
    • WP Consent API 1.0.8

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Used the sample code snippet for header.html template file as mentioned in the bug environment.

Supplemental Artifacts

  • Screenshots:

https://core.trac.wordpress.org/attachment/ticket/61826/61826_Before_Patch.jpg
https://core.trac.wordpress.org/attachment/ticket/61826/61826_After_Patch.jpg

Last edited 7 weeks ago by avinashbhosale (previous) (diff)

@avinashbhosale
7 weeks ago

Alignment before patch

@avinashbhosale
7 weeks ago

Alignment after patch

Note: See TracTickets for help on using tickets.