Make WordPress Core

Opened 4 weeks ago

Closed 8 days ago

Last modified 8 days ago

#61835 closed defect (bug) (fixed)

Update jQuery Color library

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug has-patch needs-testing
Focuses: Cc:

Description

Version 3.0.0 is now available.

The full list of changes since the last update in Core can be found on GitHub: https://github.com/jquery/jquery-color/compare/3.0.0...2.2.0.

This update notably makes changes to the library's browser and jQuery support policies and should be tested/examined closely.

  • Drop support browsers other than the latest Chrome, Firefox, Safari, and Edge
  • Drop support for jQuery <1.12 & <2.2

Attachments (3)

patch-61835.patch (3.0 KB) - added by vipulgupta003 4 weeks ago.
patch-61835.2.patch (3.0 KB) - added by vipulgupta003 4 weeks ago.
patch-61835.3.patch (3.0 KB) - added by vipulgupta003 4 weeks ago.

Download all attachments as: .zip

Change History (10)

#1 @desrosj
4 weeks ago

Dove into the history of jQuery versions. Core last shipped 1.12.x in 5.5, entirely skipping 2.x and going right to 3.3.1 for WP 5.6 in [49101] (see #50564). Since it's been over 4 years since a version of jQuery relevant to this change has shipped in Core, this update should not be a problem from that perspective.

For the change in browser support policy, Core's current policy as documented in the handbook is:

Last 1 Android versions.
Last 1 ChromeAndroid versions.
Last 2 Chrome versions.
Last 2 Firefox versions.
Last 2 Safari versions.
Last 2 iOS versions.
Last 2 Edge versions.
Last 2 Opera versions.
Browsers with > 1% usage based on can I use browser usage table

The jQuery Color README file says: "Other browsers may also work correctly with this plugin but support is not guaranteed." This seems reasonably similar to Core's policy. The current-1 version should not differ enough for this to be a problem.

#2 @vipulgupta003
4 weeks ago

Sorry, I just noticed that I accidentally added the same patch three times. All the files are identical, so any of them can be reviewed.

#3 @desrosj
4 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

Thanks @vipulgupta003! Could you also open a pull request on GitHub? This will run the entire test suite and confirm that there are no unanticipated side effects of updating this.

If you're unsure how to do this, you'll find details on the related page within the Core handbook.

This ticket was mentioned in PR #7168 on WordPress/wordpress-develop by @vipulgupta003.


4 weeks ago
#4

#5 @vipulgupta003
4 weeks ago

Hi @desrosj I have raised the PR for the same. Thanks.

#6 @desrosj
8 days ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 58956:

External Libraries: Update jQuery Color to version 3.0.0.

This update most notably drops support for jQuery < 1.12 and < 2.2. WordPress has not shipped with a version that matches these ranges since version 4.4 (see [36285]/#35380).

The update also changes the library’s browser support policy to only support the latest Chrome, Firefox, Safari, and Edge. This closely matches Core’s current policy to support the last 2 versions of these browsers. The library’s README notes that other versions nay “also work correctly with this plugin but support is not guaranteed”, which is reasonably similar.

Props vipulgupta003.
Fixes #61835.

Note: See TracTickets for help on using tickets.