Make WordPress Core

Opened 4 weeks ago

Closed 3 weeks ago

#61844 closed defect (bug) (fixed)

Twenty Fifteen : Hover effect is different in frontend and editor side for the link

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

In Twenty Fifteen, I have added a link to paragraph tag and then I can see the hover effect is different in the editor and front.

In the editor, the text colour change on hover and In the front the text decoration change as well as the colour but both sides colour are also not the same

I have attached a recording for the reference
https://www.loom.com/share/03cd069f39ce4a3c8b23e192c21133f8?sid=c21daac9-976d-4820-a215-7f1a43fe2f52

Change History (5)

This ticket was mentioned in PR #7163 on WordPress/wordpress-develop by @mi5t4n.


4 weeks ago
#1

  • Keywords has-patch added

@sabernhardt commented on PR #7163:


4 weeks ago
#2

I think this is ready.

Links rarely are focusable in the editor, so I do not think it is worth setting the outline color too. Changing the text color and removing the bottom border should be enough for those cases (such as clicking on a disabled link within the Latest Posts block).

Front:

https://github.com/user-attachments/assets/2ff2b151-fc92-47c8-88ae-29bb39f8afe1

Editors before patch:

https://github.com/user-attachments/assets/d14e2945-3512-41cd-bc6f-0a86e3bc3df6

Editors with patch:

https://github.com/user-attachments/assets/deec9865-6fc7-4da0-ae5a-fe8052ef7389

#3 @sabernhardt
4 weeks ago

  • Milestone changed from Awaiting Review to 6.7

#4 @karmatosed
3 weeks ago

  • Keywords commit added
  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to look at progressing this, thanks.

#5 @karmatosed
3 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58910:

Twenty Fifteen: Fixes hover effect being different in editors for link.

The link hover effect was different between the editor and front. As links are rarely focusable in the editor this patch does not set the outline color also.

Props pitamdey, sabernhardt, mi5t4n.
Fixes #61844.

Note: See TracTickets for help on using tickets.